Forum: Rails-core (closed, excessive spam) [PATCH] better mailer generator, tests (needs review)

8f93a872e399bc1353cc8d4e791d5401?d=identicon&s=25 Mislav MarohniÄ? (mislav)
on 2008-04-19 00:20
(Received via mailing list)
Hello there,

The model generated by mailer generator isn't exactly nice.
I've created a patch to fix this:
http://rails.lighthouseapp.com/projects/8994-ruby-...

Three commits (patchfiles) for 3 things:

   1. major generator tests cleanup and adding of mailer generator test
   2. nicer generated model
   3. added "default_url_options[:host]"

What do you think of the resulting model? Need feedback on this.
Thanks,

- Mislav
8f93a872e399bc1353cc8d4e791d5401?d=identicon&s=25 Mislav MarohniÄ? (mislav)
on 2008-04-19 00:30
(Received via mailing list)
Nevermind this, people. Josh Peek accepted and commited even before I
finished this email (but I haven't seen it then). Thanks, Josh.

On Sat, Apr 19, 2008 at 12:19 AM, Mislav Marohnić
<mislav.marohnic@gmail.com>
This topic is locked and can not be replied to.