# Workitem #6244 - request for code review

**URL:** <https://www.ruby-forum.com/t/workitem-6244-request-for-code-review/210157>\
**Category:** IronRuby\
**Created:** [August 1, 2011, 3:34pm UTC](https://www.ruby-forum.com/t/workitem-6244-request-for-code-review/210157 "2011-08-01T15:34:47Z")\
**Posts on this page:** 3\
**Page:** 1

<div class="post-metadata">

**Author:** ![dubstep](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/d/cdc98d/32.png) [@dubstep](https://www.ruby-forum.com/u/dubstep)\
**Post date:** [August 1, 2011, 3:34pm UTC](https://www.ruby-forum.com/t/workitem-6244-request-for-code-review/210157/1 "2011-08-01T15:34:47Z")

</div>

Hi, i fixed workitem #6244 (  
[workitem #6244, added format '%N' to time.strftime · enricosada/IronLanguages@c9d8339 · GitHub](https://github.com/enricosada/IronLanguages/commit/c9d8339441e21a90216b9b51cffd23f5225d0174)),  
i added ‘%N’ option to time.strftime.

I added also the test to strftime mspec. I dont think i need to change  
ironruby-tags-19, because the new test should pass now.

This is my first commit to ironruby, wiki say i need to ask to ml for  
code  
review before pull request. There is other i need to do?

---

<div class="post-metadata">

**Author:** ![estro](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/e/838e76/32.png) [@estro](https://www.ruby-forum.com/u/estro)\
**Post date:** [August 1, 2011, 5:01pm UTC](https://www.ruby-forum.com/t/workitem-6244-request-for-code-review/210157/2 "2011-08-01T17:01:13Z")

</div>

Thanks! Looks good. Submit a pull request and I’ll merge it in.

You can submit a pull request along with sending it to the mailing list  
for code review; it’s a good way to keep track of open reviews.

~js

---

<div class="post-metadata">

**Author:** ![estro](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/e/838e76/32.png) [@estro](https://www.ruby-forum.com/u/estro)\
**Post date:** [August 1, 2011, 5:36pm UTC](https://www.ruby-forum.com/t/workitem-6244-request-for-code-review/210157/3 "2011-08-01T17:36:24Z")

</div>

On a related note, we should come up with a better way to keep our copy  
of RubySpec in sync with the “truth”:  
[https://github.com/rubyspec/rubyspec/](https://github.com/rubyspec/rubyspec/). Volunteers welcome.