# Upgrading to rails 1.2.3 from 1.1.6 - problem with redirect\_

**URL:** <https://www.ruby-forum.com/t/upgrading-to-rails-1-2-3-from-1-1-6-problem-with-redirect/104397>\
**Category:** Rails\
**Created:** [May 17, 2007, 3:43pm UTC](https://www.ruby-forum.com/t/upgrading-to-rails-1-2-3-from-1-1-6-problem-with-redirect/104397 "2007-05-17T15:43:28Z")\
**Posts on this page:** 2\
**Page:** 1

<div class="post-metadata">

**Author:** ![dan.hatfield](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/d/ea666f/32.png) [@dan.hatfield](https://www.ruby-forum.com/u/dan.hatfield)\
**Post date:** [May 17, 2007, 3:43pm UTC](https://www.ruby-forum.com/t/upgrading-to-rails-1-2-3-from-1-1-6-problem-with-redirect/104397/1 "2007-05-17T15:43:28Z")

</div>

I’m trying to upgrdade from rails 1.1.6 to rails 1.2.3 and I’m running  
into a difference  
with redirect\_to that is causing a DoubleRenderError.

Here’s my code (I’m using a variant of paranoid sql session store):

before\_filter :touch\_session, :except =\> [:login, :logout]  
after\_filter :touch\_session

def touch\_session

# NOTE: I rewrote reset\_session in action\_controller\_cgi\_request\_hack

```
    if session[:user_id] == nil
flash[:notice] = "Please log in"
redirect_to(:controller => "login" , :action => "login" )

```

else  
reset\_session unless session.host.nil? || session.host ==  
request.remote\_ip  
session.host ||= request.remote\_ip  
session.user ||= session[:user\_id]  
end  
end

In Rails 1.1.6, this worked fine, in Rails 1.2.3 this throws a  
DoubleRenderError.

I tried to fix this as so:

def touch\_session

# NOTE: I rewrote reset\_session in action\_controller\_cgi\_request\_hack

```
    if session[:user_id] == nil
flash[:notice] = "Please log in"
redirect_to(:controller => "login" , :action => "login" )
return false

```

else  
reset\_session unless session.host.nil? || session.host ==  
request.remote\_ip  
session.host ||= request.remote\_ip  
session.user ||= session[:user\_id]  
return true  
end  
end

But that had no effect. Any ideas? I’m sure I’m doing something wrong  
here but not sure what.  
There is no other render or redirect after this and since I’m  
returning false from the before\_filter I thought processing should  
stop.

---

<div class="post-metadata">

**Author:** ![dan.hatfield](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/d/ea666f/32.png) [@dan.hatfield](https://www.ruby-forum.com/u/dan.hatfield)\
**Post date:** [June 5, 2007, 3:36am UTC](https://www.ruby-forum.com/t/upgrading-to-rails-1-2-3-from-1-1-6-problem-with-redirect/104397/2 "2007-06-05T03:36:29Z")

</div>

Have you tried using…

redirect\_to(:controller =\> “login” , :action =\> “login” ) and return  
false

…?

T