# \[RFC\] link\_if\_authorized bug/TODO patch **URL:** \ **Category:** Engines\ **Created:** [February 14, 2006, 3:26am UTC](https://www.ruby-forum.com/t/rfc-link-if-authorized-bug-todo-patch/53741 "2006-02-14T03:26:19Z")\ **Posts on this page:** 3\ **Page:** 1
**Author:** ![jay-levitt](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/j/a88e57/32.png) [@jay-levitt](https://www.ruby-forum.com/u/jay-levitt)\ **Post date:** [February 14, 2006, 3:26am UTC](https://www.ruby-forum.com/t/rfc-link-if-authorized-bug-todo-patch/53741/1 "2006-02-14T03:26:19Z")
There’s a bug in link\_if\_authorized that includes the :wrap\_in hash as an attribute of the A tag, even though it tries to delete it. There’s also a noted TODO that things like :id will propagate to both the A and the wrapper element. I think this patch should solve that. :wrap\_in now takes either the old string element, or a new hash, consisting of (a) :tag=\>“li/div/etc”, and (b) anything else. I’m a very novice Ruby programmer, so if someone (hi James) could eyeball this and tell me if it does anything obviously stupid, I’ll code up some tests and submit it in Trac. # Index: C:/dev/src/eclipse/radio/radiostar/vendor/plugins/user\_engine/lib/user\_engine.rb * * * C:/dev/src/eclipse/radio/radiostar/vendor/plugins/user\_engine/lib/user\_engine.rb (revision 39) +++ C:/dev/src/eclipse/radio/radiostar/vendor/plugins/user\_engine/lib/user\_engine.rb (working copy) @@ -156,13 +156,22 @@ end ``` (block.nil? || (yield block)) && authorized?(auth_options) { ``` - ``` #result = link_to_with_current_styling(name, options, ``` html\_options, \*params) - ``` wrap_in = html_options.delete(:wrap_in) result = link_to(name, options, html_options, *params) ``` - - ``` # TODO: won't this pass other things like html_options[:id], ``` which is EVIL since two - ``` # things shouldn't share the same ID. ``` - ``` wrap_tag = html_options.delete(:wrap_in) ``` - ``` result = content_tag(wrap_tag, result, html_options) if wrap_tag ``` != nil - ``` if wrap_in != nil ``` - ``` if Hash === wrap_in ``` - ``` wrap_tag = wrap_in.delete(:tag) ``` - ``` wrap_options = wrap_in ``` - ``` p "it's a hash" ``` - ``` else ``` - ``` wrap_tag = wrap_in ``` - ``` wrap_options = nil ``` - ``` p "wrap_tag: " ``` - ``` p wrap_tag ``` - ``` end ``` - - ``` result = content_tag(wrap_tag, result, wrap_options) ``` - ``` end ``` } result end Jay L. ---
**Author:** ![jay-levitt](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/j/a88e57/32.png) [@jay-levitt](https://www.ruby-forum.com/u/jay-levitt)\ **Post date:** [February 14, 2006, 5:43pm UTC](https://www.ruby-forum.com/t/rfc-link-if-authorized-bug-todo-patch/53741/2 "2006-02-14T17:43:55Z")
On Mon, 13 Feb 2006 21:26:46 -0500, Jay L. wrote: > There’s a bug in link\_if\_authorized that includes the :wrap\_in hash as an > attribute of the A tag, even though it tries to delete it. There’s also > a noted TODO that things like :id will propagate to both the A and the wrapper > element. > > I think this patch should solve that. Wow! My newsreader somehow added mediocre, print-statement-style debugging code to my patch before posting it! How odd! I’d better go, uh, report that newsreader bug. Yeah, that’s it. Jay ---
**Author:** ![jay-levitt](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/j/a88e57/32.png) [@jay-levitt](https://www.ruby-forum.com/u/jay-levitt)\ **Post date:** [February 15, 2006, 11:08pm UTC](https://www.ruby-forum.com/t/rfc-link-if-authorized-bug-todo-patch/53741/3 "2006-02-15T23:08:33Z")
Hi Jay, Could you submit this patch to the Trac site? Also if you could write some tests for it that would be even better - I know the User Engine needs some TDD love at the moment… Thanks! - james On 2/14/06, Jay L. [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) wrote: > this and tell me if it does anything obviously stupid, I’ll code up some > > - > > ``` > #result = link_to_with_current_styling(name, options, html_options, *params) > > ``` > > - > > ``` > wrap_options = wrap_in > > ``` > > } – - J \* ~