# Review: miscellaneous fixes **URL:** \ **Category:** IronRuby\ **Created:** [August 20, 2010, 9:13pm UTC](https://www.ruby-forum.com/t/review-miscellaneous-fixes/193632 "2010-08-20T21:13:48Z")\ **Posts on this page:** 5\ **Page:** 1
**Author:** ![murena](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/m/7ba0ec/32.png) [@murena](https://www.ruby-forum.com/u/murena)\ **Post date:** [August 20, 2010, 9:13pm UTC](https://www.ruby-forum.com/t/review-miscellaneous-fixes/193632/1 "2010-08-20T21:13:48Z")
Hi, today I’ve finally started fixing some failing specs in the core libraries of IronRuby (well actually I spent most of the time reviewing the smaller changes between MRI 1.8 and 1.9 and reading some parts of the source code of IronRuby since it’s been quite some time since the last time I contributed). I still have to push my changes on a remote repository but in the meantime you can find them in the diff attached to this email. 304459b Implement various fixes to Kernel and Array related to the trust status of Object instances. e77abb5 Fix: Kernel#taint and Kernel#untaint raise an exception when trying to modify the taint status of a frozen object. 3f0760b Fix: Array#pop raises a RuntimeError on a frozen array. 9e4defb Implement Array#pop(n). 1ba0628 Fix: Object#=~ returns nil matching any object. 19e8250 Update the unsigned version of App.config to pick the right library paths for 1.9. A few question / notes: - If nothing has changed since the last time, I guess you can’t still merge changes coming from the community that don’t apply to parts of IronRuby outside Libraries.LCA\_RESTRICTED, right? - I noticed that the contents of .gitignore have been changed in the master branch and now it contains only one line. I wonder if this change is intentional, now I get a lot of garbage (e.g. the output of the compilation) in the list of unstaged changes. - Many specs of Array, Hash and String fail because MRI 1.9 now raises a RuntimeError instead of a TypeError when trying to modify a frozen object. The change in [http://github.com/ironruby/ironruby/blob/d0fcc0a132c1ca4f07a11369293d1c5801a6a0d3/Languages/Ruby/Ruby/Runtime/RubyExceptions.cs#L49](http://github.com/ironruby/ironruby/blob/d0fcc0a132c1ca4f07a11369293d1c5801a6a0d3/Languages/Ruby/Ruby/Runtime/RubyExceptions.cs#L49) is trivial though. - The checks I added when modiying taintness or trustiness on frozen objects should be moved inside RubyContext, respectively to SetObjectTaint() SetObjectTrustiness(). - It would be nice to have a TrustObjectBy(RubyContext, Object) method in RubyContext. - If you are wondering why I haven’t implemented the last three items myself, see my first question 🙂 Thanks, Daniele ---
**Author:** ![murena](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/m/7ba0ec/32.png) [@murena](https://www.ruby-forum.com/u/murena)\ **Post date:** [August 22, 2010, 2:48am UTC](https://www.ruby-forum.com/t/review-miscellaneous-fixes/193632/2 "2010-08-22T02:48:28Z")
Thanks for the patch! Jim, could you look at that? [Inline] ---
**Author:** ![murena](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/m/7ba0ec/32.png) [@murena](https://www.ruby-forum.com/u/murena)\ **Post date:** [August 22, 2010, 4:33am UTC](https://www.ruby-forum.com/t/review-miscellaneous-fixes/193632/3 "2010-08-22T04:33:12Z")
I’ve already fixed this in my fork … just reverted the mistake change: [http://github.com/jschementi/ironruby/commit/271532b3e9bd25a00153cf1c633c582b5c7101d1](http://github.com/jschementi/ironruby/commit/271532b3e9bd25a00153cf1c633c582b5c7101d1) ~Jimmy On Sat, Aug 21, 2010 at 8:43 PM, Tomas M. \< ---
**Author:** ![murena](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/m/7ba0ec/32.png) [@murena](https://www.ruby-forum.com/u/murena)\ **Post date:** [September 2, 2010, 7:57pm UTC](https://www.ruby-forum.com/t/review-miscellaneous-fixes/193632/4 "2010-09-02T19:57:00Z")
I’ve just merged your changes into the main repo. Sorry for the delay, we had some technical problems with our sync server. Tomas ---
**Author:** ![murena](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/m/7ba0ec/32.png) [@murena](https://www.ruby-forum.com/u/murena)\ **Post date:** [August 22, 2010, 11:55am UTC](https://www.ruby-forum.com/t/review-miscellaneous-fixes/193632/5 "2010-08-22T11:55:36Z")
On Sun, Aug 22, 2010 at 02:43, Tomas M. [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) wrote: I have rebased my local branch on top of your latest changes and removed the unneeded commits, now everything is available on my remote repository in a separate topic branch (see [GitHub - nrk/ironruby at corelib19 · GitHub](http://github.com/nrk/ironruby/tree/corelib19)). The three commits “survived” are: 793effd Implement Array#pop(n). 503002f Fix: Object#=~ returns nil matching any object. 7a6275b Update the unsigned version of App.config to pick the right library paths for 1.9. See > **[Comparing 014e640ed27c28ff97fb...793effd4d75f39f36ff3 · nrk/ironruby](https://github.com/nrk/ironruby/compare/014e640ed27c28ff97fb...793effd4d75f39f36ff3)** > > Microsoft's Ruby language compiler that is built on top of the Dynamic Language Runtime. - Comparing 014e640ed27c28ff97fb...793effd4d75f39f36ff3 · nrk/ironruby There are also new changes in that branch, but I’m going to post a new message with a separate diff for those. > 304459b Implement various fixes to Kernel and Array related to the trust > status of Object instances. > > [Better fix would be: > return stream.String.TaintBy(format); Fix applied… and it actually lead me to notice a bug related to operations on the trust status of MutableString instances (see below): > > > “”.untrust > > > =\> “” > > > “”.untrust.untrust > > > (ir):1:in `untrust': can't modify frozen object (RuntimeError) from (ir):1 "".untrust.trust (ir):1:in `trust’: can’t modify frozen object (RuntimeError) > > > from (ir):1 > > > “”.trust.untrust > > > =\> “” > Note that context.TaintObjectBy should only be used on objects that are not > statically typed to a type that implements IRubyObjectState. MutableString > does. Ah, right! > > - If nothing has changed since the last time, I guess you can’t still merge > > changes coming from the community that don’t apply to parts of IronRuby > > outside Libraries.LCA\_RESTRICTED, right? > [Nothing changed yet.] I think I still need to find a decent workflow when working on stuff that can’t be merged back by you because of the current constraints, maybe I’ll just limit myself to do some experiments in a further branch and report back just like I did in my previous mail. > [I’m not sure this is needed. Instead I modified TaintObjectBy to copy > trustiness as well - it seems that most of the time “trust” and “taint” are > both copied. > This makes the changes in KernelOps.cs unnecessary (Clone, Trust, Untrust, > Taint, Untaint). And also the change in IListOps.Repetition and Compact. > ] If trust and taint are both copied then yes, I agree that’s the way to go. I just wasn’t sure about this behaviour so I thought that keeping them separate (with maybe a new method in RubyContext such as CopyFlags or anything along this line) might have been safer. – Daniele A. > **[clorophilla.net](https://clorophilla.net/)** [http://twitter.com/JoL1hAHN](http://twitter.com/JoL1hAHN)