# Review: Misc fixes

**URL:** <https://www.ruby-forum.com/t/review-misc-fixes/165464>\
**Category:** IronRuby\
**Created:** [April 14, 2009, 7:14am UTC](https://www.ruby-forum.com/t/review-misc-fixes/165464 "2009-04-14T07:14:49Z")\
**Posts on this page:** 2\
**Page:** 1

<div class="post-metadata">

**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\
**Post date:** [April 14, 2009, 7:14am UTC](https://www.ruby-forum.com/t/review-misc-fixes/165464/1 "2009-04-14T07:14:49Z")

</div>

> <https://github.com/shri-zz/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead>
>
> Fixes File apis to throw correct exception type
> Implements Kernel.abort
> Adds Err…no::ECONNREFUSED
> Exception#message should call Exception#to\_s
> Fixes paths in rbconfig.rb to work in dev environment

GitDiff.bat 5e8c6b232a3c952985adbf1b9cda5c456d503cea  
24ce7ba7cdac9a52d3f43dbd77300f5067d31ead

- 

```
    Fixes File.expand_path to workaround a problem "igem i rails" 

```

was running into.

- 

```
    Fixes File apis to throw correct exception type

```

- 

```
    Implements Kernel.abort

```

- 

```
    Adds Errno::ECONNREFUSED

```

- 

```
    Exception#message should call Exception#to_s

```

- 

```
    Fixes paths in rbconfig.rb to work in dev environment

```

Files changed:

- 

.gitignore[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-0](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-0)  
\*  
Merlin/External.LCA\_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/file/expand\_path\_tags.txt[http://github.com/shri/ironruby/tree/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead/Merlin/External.LCA\_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/file/expand\_path\_tags.txt](http://github.com/shri/ironruby/tree/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead/Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/file/expand_path_tags.txt)  
\*  
Merlin/External.LCA\_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/string/split\_tags.txt[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-2](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-2)  
\*  
Merlin/External.LCA\_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/exception/message\_spec.rb[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-3](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-3)  
\*  
Merlin/External.LCA\_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/exception/to\_s\_spec.rb[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-4](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-4)  
\*  
Merlin/External.LCA\_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/file/expand\_path\_spec.rb[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-5](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-5)  
\*  
Merlin/External.LCA\_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/file/open\_spec.rb[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-6](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-6)  
\*  
Merlin/External.LCA\_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/file/rename\_spec.rb[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-7](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-7)  
\*  
Merlin/External.LCA\_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/file/shared/unlink.rb[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-8](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-8)  
\*  
Merlin/External.LCA\_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/kernel/abort\_spec.rb[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-9](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-9)  
\*  
Merlin/External.LCA\_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/kernel/open\_spec.rb[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-10](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-10)  
\*  
Merlin/External.LCA\_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/string/split\_spec.rb[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-11](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-11)  
\*  
Merlin/Main/Languages/Ruby/Libraries.LCA\_RESTRICTED/Builtins/Errno.cs[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-12](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-12)  
\*  
Merlin/Main/Languages/Ruby/Libraries.LCA\_RESTRICTED/Builtins/ExceptionOps.cs[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-13](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-13)  
\*  
Merlin/Main/Languages/Ruby/Libraries.LCA\_RESTRICTED/Builtins/FileOps.cs[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-14](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-14)  
\*  
Merlin/Main/Languages/Ruby/Libraries.LCA\_RESTRICTED/Builtins/KernelOps.cs[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-15](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-15)  
\*  
Merlin/Main/Languages/Ruby/Libraries.LCA\_RESTRICTED/Builtins/MutableStringOps.cs[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-16](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-16)  
\*  
Merlin/Main/Languages/Ruby/Libraries.LCA\_RESTRICTED/Initializers.Generated.cs[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-17](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-17)  
\*  
Merlin/Main/Languages/Ruby/Libs/rbconfig.rb[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-18](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-18)  
\*  
Merlin/Main/Languages/Ruby/Ruby/Builtins/File.cs[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-19](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-19)

Thanks,  
Shri

---

<div class="post-metadata">

**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\
**Post date:** [April 14, 2009, 9:13pm UTC](https://www.ruby-forum.com/t/review-misc-fixes/165464/2 "2009-04-14T21:13:25Z")

</div>

> <https://github.com/shri-zz/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#L3L4>
>
> Fixes File apis to throw correct exception type
> Implements Kernel.abort
> Adds Err…no::ECONNREFUSED
> Exception#message should call Exception#to\_s
> Fixes paths in rbconfig.rb to work in dev environment

- 

```
    Undo this deletion. That is a valid spec as well.

```

> <https://github.com/shri-zz/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#L5R29>
>
> Fixes File apis to throw correct exception type
> Implements Kernel.abort
> Adds Err…no::ECONNREFUSED
> Exception#message should call Exception#to\_s
> Fixes paths in rbconfig.rb to work in dev environment

- 

```
    Guards don't go inside of examples. Please split this into two 

```

specs: one guarded, the other unguarded.

> <https://github.com/shri-zz/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#L10L91>
>
> Fixes File apis to throw correct exception type
> Implements Kernel.abort
> Adds Err…no::ECONNREFUSED
> Exception#message should call Exception#to\_s
> Fixes paths in rbconfig.rb to work in dev environment

- 

```
    I would keep the :in_block in the spec to be sure that it 

```

isn’t a no-op

Test and .rb changes look good other than that.

JD

From: removed\_email\_address@domain.invalid  
[[mailto:removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid)] On Behalf Of Shri B.  
Sent: Monday, April 13, 2009 10:14 PM  
To: IronRuby External Code R.  
Cc: removed\_email\_address@domain.invalid  
Subject: [Ironruby-core] Review: Misc fixes

> <https://github.com/shri-zz/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead>
>
> Fixes File apis to throw correct exception type
> Implements Kernel.abort
> Adds Err…no::ECONNREFUSED
> Exception#message should call Exception#to\_s
> Fixes paths in rbconfig.rb to work in dev environment

GitDiff.bat 5e8c6b232a3c952985adbf1b9cda5c456d503cea  
24ce7ba7cdac9a52d3f43dbd77300f5067d31ead

- 

```
    Fixes File.expand_path to workaround a problem "igem i rails" 

```

was running into.

- 

```
    Fixes File apis to throw correct exception type

```

- 

```
    Implements Kernel.abort

```

- 

```
    Adds Errno::ECONNREFUSED

```

- 

```
    Exception#message should call Exception#to_s

```

- 

```
    Fixes paths in rbconfig.rb to work in dev environment

```

Files changed:

- 

.gitignore[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-0](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-0)  
\*  
Merlin/External.LCA\_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/file/expand\_path\_tags.txt[http://github.com/shri/ironruby/tree/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead/Merlin/External.LCA\_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/file/expand\_path\_tags.txt](http://github.com/shri/ironruby/tree/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead/Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/file/expand_path_tags.txt)  
\*  
Merlin/External.LCA\_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/string/split\_tags.txt[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-2](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-2)  
\*  
Merlin/External.LCA\_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/exception/message\_spec.rb[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-3](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-3)  
\*  
Merlin/External.LCA\_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/exception/to\_s\_spec.rb[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-4](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-4)  
\*  
Merlin/External.LCA\_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/file/expand\_path\_spec.rb[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-5](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-5)  
\*  
Merlin/External.LCA\_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/file/open\_spec.rb[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-6](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-6)  
\*  
Merlin/External.LCA\_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/file/rename\_spec.rb[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-7](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-7)  
\*  
Merlin/External.LCA\_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/file/shared/unlink.rb[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-8](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-8)  
\*  
Merlin/External.LCA\_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/kernel/abort\_spec.rb[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-9](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-9)  
\*  
Merlin/External.LCA\_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/kernel/open\_spec.rb[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-10](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-10)  
\*  
Merlin/External.LCA\_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/string/split\_spec.rb[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-11](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-11)  
\*  
Merlin/Main/Languages/Ruby/Libraries.LCA\_RESTRICTED/Builtins/Errno.cs[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-12](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-12)  
\*  
Merlin/Main/Languages/Ruby/Libraries.LCA\_RESTRICTED/Builtins/ExceptionOps.cs[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-13](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-13)  
\*  
Merlin/Main/Languages/Ruby/Libraries.LCA\_RESTRICTED/Builtins/FileOps.cs[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-14](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-14)  
\*  
Merlin/Main/Languages/Ruby/Libraries.LCA\_RESTRICTED/Builtins/KernelOps.cs[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-15](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-15)  
\*  
Merlin/Main/Languages/Ruby/Libraries.LCA\_RESTRICTED/Builtins/MutableStringOps.cs[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-16](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-16)  
\*  
Merlin/Main/Languages/Ruby/Libraries.LCA\_RESTRICTED/Initializers.Generated.cs[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-17](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-17)  
\*  
Merlin/Main/Languages/Ruby/Libs/rbconfig.rb[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-18](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-18)  
\*  
Merlin/Main/Languages/Ruby/Ruby/Builtins/File.cs[http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-19](http://github.com/shri/ironruby/commit/24ce7ba7cdac9a52d3f43dbd77300f5067d31ead#diff-19)

Thanks,  
Shri