# Review: Misc fixes to tests

**URL:** <https://www.ruby-forum.com/t/review-misc-fixes-to-tests/169454>\
**Category:** IronRuby\
**Created:** [June 3, 2009, 10:38pm UTC](https://www.ruby-forum.com/t/review-misc-fixes-to-tests/169454 "2009-06-03T22:38:55Z")\
**Posts on this page:** 3\
**Page:** 1

<div class="post-metadata">

**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\
**Post date:** [June 3, 2009, 10:38pm UTC](https://www.ruby-forum.com/t/review-misc-fixes-to-tests/169454/1 "2009-06-03T22:38:55Z")

</div>

> <https://github.com/shri-zz/ironruby/commit/4008955a15895eb0ad02fdbee257ac500a63efe1>
>
> Changed default.mspec so that :core properly excludes the thread tests

Fix non-deterministic Rake test for “multitask” by adding  
semaphore.synchronize around array access  
Changed default.mspec so that :core properly excludes the thread tests  
(reviewed by Jim)

- 

Merlin/External.LCA\_RESTRICTED/Languages/IronRuby/mspec/default.mspec[http://github.com/shri/ironruby/commit/4008955a15895eb0ad02fdbee257ac500a63efe1#diff-0](http://github.com/shri/ironruby/commit/4008955a15895eb0ad02fdbee257ac500a63efe1#diff-0)  
(reviewed by Jim)  
\*  
Merlin/External.LCA\_RESTRICTED/Languages/Ruby/RakeTests/test/test\_multitask.rb[http://github.com/shri/ironruby/commit/4008955a15895eb0ad02fdbee257ac500a63efe1#diff-1](http://github.com/shri/ironruby/commit/4008955a15895eb0ad02fdbee257ac500a63efe1#diff-1)  
\*  
Merlin/Main/Languages/Ruby/Scripts/irtests.bat[http://github.com/shri/ironruby/commit/4008955a15895eb0ad02fdbee257ac500a63efe1#diff-2](http://github.com/shri/ironruby/commit/4008955a15895eb0ad02fdbee257ac500a63efe1#diff-2)  
\*  
Merlin/Users/sborde/Dev.bat[http://github.com/shri/ironruby/commit/4008955a15895eb0ad02fdbee257ac500a63efe1#diff-3](http://github.com/shri/ironruby/commit/4008955a15895eb0ad02fdbee257ac500a63efe1#diff-3)  
Thanks,  
Shri

---

<div class="post-metadata">

**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\
**Post date:** [June 3, 2009, 10:41pm UTC](https://www.ruby-forum.com/t/review-misc-fixes-to-tests/169454/2 "2009-06-03T22:41:52Z")

</div>

The rest looks good too.

JD

…there is no try

From: Shri B.  
Sent: Wednesday, June 03, 2009 1:34 PM  
To: removed\_email\_address@domain.invalid  
Cc: IronRuby External Code R.  
Subject: Review: Misc fixes to tests

> <https://github.com/shri-zz/ironruby/commit/4008955a15895eb0ad02fdbee257ac500a63efe1>
>
> Changed default.mspec so that :core properly excludes the thread tests

Fix non-deterministic Rake test for “multitask” by adding  
semaphore.synchronize around array access  
Changed default.mspec so that :core properly excludes the thread tests  
(reviewed by Jim)

- 

Merlin/External.LCA\_RESTRICTED/Languages/IronRuby/mspec/default.mspec[http://github.com/shri/ironruby/commit/4008955a15895eb0ad02fdbee257ac500a63efe1#diff-0](http://github.com/shri/ironruby/commit/4008955a15895eb0ad02fdbee257ac500a63efe1#diff-0)  
(reviewed by Jim)  
\*  
Merlin/External.LCA\_RESTRICTED/Languages/Ruby/RakeTests/test/test\_multitask.rb[http://github.com/shri/ironruby/commit/4008955a15895eb0ad02fdbee257ac500a63efe1#diff-1](http://github.com/shri/ironruby/commit/4008955a15895eb0ad02fdbee257ac500a63efe1#diff-1)  
\*  
Merlin/Main/Languages/Ruby/Scripts/irtests.bat[http://github.com/shri/ironruby/commit/4008955a15895eb0ad02fdbee257ac500a63efe1#diff-2](http://github.com/shri/ironruby/commit/4008955a15895eb0ad02fdbee257ac500a63efe1#diff-2)  
\*  
Merlin/Users/sborde/Dev.bat[http://github.com/shri/ironruby/commit/4008955a15895eb0ad02fdbee257ac500a63efe1#diff-3](http://github.com/shri/ironruby/commit/4008955a15895eb0ad02fdbee257ac500a63efe1#diff-3)  
Thanks,  
Shri

---

<div class="post-metadata">

**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\
**Post date:** [June 4, 2009, 2:12am UTC](https://www.ruby-forum.com/t/review-misc-fixes-to-tests/169454/3 "2009-06-04T02:12:48Z")

</div>

Looks good

From: Shri B.  
Sent: Wednesday, June 03, 2009 1:34 PM  
To: removed\_email\_address@domain.invalid  
Cc: IronRuby External Code R.  
Subject: Review: Misc fixes to tests

> <https://github.com/shri-zz/ironruby/commit/4008955a15895eb0ad02fdbee257ac500a63efe1>
>
> Changed default.mspec so that :core properly excludes the thread tests

Fix non-deterministic Rake test for “multitask” by adding  
semaphore.synchronize around array access  
Changed default.mspec so that :core properly excludes the thread tests  
(reviewed by Jim)

- 

Merlin/External.LCA\_RESTRICTED/Languages/IronRuby/mspec/default.mspec[http://github.com/shri/ironruby/commit/4008955a15895eb0ad02fdbee257ac500a63efe1#diff-0](http://github.com/shri/ironruby/commit/4008955a15895eb0ad02fdbee257ac500a63efe1#diff-0)  
(reviewed by Jim)  
\*  
Merlin/External.LCA\_RESTRICTED/Languages/Ruby/RakeTests/test/test\_multitask.rb[http://github.com/shri/ironruby/commit/4008955a15895eb0ad02fdbee257ac500a63efe1#diff-1](http://github.com/shri/ironruby/commit/4008955a15895eb0ad02fdbee257ac500a63efe1#diff-1)  
\*  
Merlin/Main/Languages/Ruby/Scripts/irtests.bat[http://github.com/shri/ironruby/commit/4008955a15895eb0ad02fdbee257ac500a63efe1#diff-2](http://github.com/shri/ironruby/commit/4008955a15895eb0ad02fdbee257ac500a63efe1#diff-2)  
\*  
Merlin/Users/sborde/Dev.bat[http://github.com/shri/ironruby/commit/4008955a15895eb0ad02fdbee257ac500a63efe1#diff-3](http://github.com/shri/ironruby/commit/4008955a15895eb0ad02fdbee257ac500a63efe1#diff-3)  
Thanks,  
Shri