# Review: Marshal bug

**URL:** <https://www.ruby-forum.com/t/review-marshal-bug/164030>\
**Category:** IronRuby\
**Created:** [March 27, 2009, 1:53am UTC](https://www.ruby-forum.com/t/review-marshal-bug/164030 "2009-03-27T01:53:34Z")\
**Posts on this page:** 3\
**Page:** 1

<div class="post-metadata">

**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\
**Post date:** [March 27, 2009, 1:53am UTC](https://www.ruby-forum.com/t/review-marshal-bug/164030/1 "2009-03-27T01:53:34Z")

</div>

GitDiff.bat a90a89465f3b9c178507f83e4797481463989059  
119b056332b270164eaf2b1f9cd2956387e38636

> <https://github.com/shri-zz/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636>
>
> Changed igem.bat, irake.bat, etc to work in dev environment where ir.exe is not …in the path
> File.expand\_path("~") should throw ArgumentError is HOME is not set

YAML should allow spaces. eg the trailing \s\t in YAML.load(“!timestamp  
‘2009-03-22 00:00:00\s\t’”) is allowed  
Changed igem.bat, irake.bat, etc to work in dev environment where ir.exe  
is not in the path  
File.expand\_path(“~”) should throw ArgumentError is HOME is not set

- 

Merlin/External/Languages/IronRuby/Yaml/IronRuby.Libraries.Yaml/Engine/BaseConstructor.cs[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-0](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-0)  
\*  
Merlin/External/Languages/IronRuby/Yaml/IronRuby.Libraries.Yaml/Engine/Scanner.cs[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-1](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-1)  
\*  
Merlin/External/Languages/IronRuby/mspec/rubyspec/core/file/expand\_path\_spec.rb[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-2](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-2)  
\*  
Merlin/External/Languages/IronRuby/mspec/rubyspec/core/marshal/fixtures/marshal\_data.rb[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-3](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-3)  
\*  
Merlin/External/Languages/IronRuby/mspec/rubyspec/library/yaml/load\_spec.rb[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-4](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-4)  
\*  
Merlin/Main/Languages/Ruby/Libraries.LCA\_RESTRICTED/Builtins/FileOps.cs[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-5](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-5)  
\*  
Merlin/Main/Languages/Ruby/Libraries.LCA\_RESTRICTED/Builtins/Marshal.cs[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-6](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-6)  
\*  
Merlin/Main/Languages/Ruby/Scripts/bin/igem.bat[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-7](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-7)  
\*  
Merlin/Main/Languages/Ruby/Scripts/bin/iirb.bat[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-8](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-8)  
\*  
Merlin/Main/Languages/Ruby/Scripts/bin/irails.bat[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-9](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-9)  
\*  
Merlin/Main/Languages/Ruby/Scripts/bin/irake.bat[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-10](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-10)  
\*  
Merlin/Main/Languages/Ruby/Scripts/bin/irdoc.bat[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-11](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-11)  
\*  
Merlin/Main/Languages/Ruby/Scripts/bin/iri.bat[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-12](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-12)

Thanks,  
Shri

---

<div class="post-metadata">

**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\
**Post date:** [March 27, 2009, 9:18pm UTC](https://www.ruby-forum.com/t/review-marshal-bug/164030/2 "2009-03-27T21:18:09Z")

</div>

Library changes look good.

Tomas

From: Shri B.  
Sent: Thursday, March 26, 2009 4:35 PM  
To: IronRuby External Code R.  
Cc: removed\_email\_address@domain.invalid  
Subject: Review: Marshal bug

GitDiff.bat a90a89465f3b9c178507f83e4797481463989059  
119b056332b270164eaf2b1f9cd2956387e38636

> <https://github.com/shri-zz/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636>
>
> Changed igem.bat, irake.bat, etc to work in dev environment where ir.exe is not …in the path
> File.expand\_path("~") should throw ArgumentError is HOME is not set

YAML should allow spaces. eg the trailing \s\t in YAML.load(“!timestamp  
‘2009-03-22 00:00:00\s\t’”) is allowed  
Changed igem.bat, irake.bat, etc to work in dev environment where ir.exe  
is not in the path  
File.expand\_path(“~”) should throw ArgumentError is HOME is not set

- 

Merlin/External/Languages/IronRuby/Yaml/IronRuby.Libraries.Yaml/Engine/BaseConstructor.cs[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-0](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-0)  
\*  
Merlin/External/Languages/IronRuby/Yaml/IronRuby.Libraries.Yaml/Engine/Scanner.cs[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-1](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-1)  
\*  
Merlin/External/Languages/IronRuby/mspec/rubyspec/core/file/expand\_path\_spec.rb[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-2](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-2)  
\*  
Merlin/External/Languages/IronRuby/mspec/rubyspec/core/marshal/fixtures/marshal\_data.rb[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-3](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-3)  
\*  
Merlin/External/Languages/IronRuby/mspec/rubyspec/library/yaml/load\_spec.rb[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-4](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-4)  
\*  
Merlin/Main/Languages/Ruby/Libraries.LCA\_RESTRICTED/Builtins/FileOps.cs[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-5](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-5)  
\*  
Merlin/Main/Languages/Ruby/Libraries.LCA\_RESTRICTED/Builtins/Marshal.cs[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-6](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-6)  
\*  
Merlin/Main/Languages/Ruby/Scripts/bin/igem.bat[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-7](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-7)  
\*  
Merlin/Main/Languages/Ruby/Scripts/bin/iirb.bat[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-8](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-8)  
\*  
Merlin/Main/Languages/Ruby/Scripts/bin/irails.bat[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-9](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-9)  
\*  
Merlin/Main/Languages/Ruby/Scripts/bin/irake.bat[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-10](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-10)  
\*  
Merlin/Main/Languages/Ruby/Scripts/bin/irdoc.bat[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-11](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-11)  
\*  
Merlin/Main/Languages/Ruby/Scripts/bin/iri.bat[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-12](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-12)

Thanks,  
Shri

---

<div class="post-metadata">

**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\
**Post date:** [March 27, 2009, 10:27pm UTC](https://www.ruby-forum.com/t/review-marshal-bug/164030/3 "2009-03-27T22:27:27Z")

</div>

Test and batch changes look good.

JD

From: Tomas M.  
Sent: Friday, March 27, 2009 12:59 PM  
To: Shri B.; IronRuby External Code R.  
Cc: removed\_email\_address@domain.invalid  
Subject: RE: Review: Marshal bug

Library changes look good.

Tomas

From: Shri B.  
Sent: Thursday, March 26, 2009 4:35 PM  
To: IronRuby External Code R.  
Cc: removed\_email\_address@domain.invalid  
Subject: Review: Marshal bug

GitDiff.bat a90a89465f3b9c178507f83e4797481463989059  
119b056332b270164eaf2b1f9cd2956387e38636

> <https://github.com/shri-zz/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636>
>
> Changed igem.bat, irake.bat, etc to work in dev environment where ir.exe is not …in the path
> File.expand\_path("~") should throw ArgumentError is HOME is not set

YAML should allow spaces. eg the trailing \s\t in YAML.load(“!timestamp  
‘2009-03-22 00:00:00\s\t’”) is allowed  
Changed igem.bat, irake.bat, etc to work in dev environment where ir.exe  
is not in the path  
File.expand\_path(“~”) should throw ArgumentError is HOME is not set

- 

Merlin/External/Languages/IronRuby/Yaml/IronRuby.Libraries.Yaml/Engine/BaseConstructor.cs[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-0](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-0)  
\*  
Merlin/External/Languages/IronRuby/Yaml/IronRuby.Libraries.Yaml/Engine/Scanner.cs[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-1](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-1)  
\*  
Merlin/External/Languages/IronRuby/mspec/rubyspec/core/file/expand\_path\_spec.rb[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-2](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-2)  
\*  
Merlin/External/Languages/IronRuby/mspec/rubyspec/core/marshal/fixtures/marshal\_data.rb[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-3](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-3)  
\*  
Merlin/External/Languages/IronRuby/mspec/rubyspec/library/yaml/load\_spec.rb[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-4](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-4)  
\*  
Merlin/Main/Languages/Ruby/Libraries.LCA\_RESTRICTED/Builtins/FileOps.cs[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-5](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-5)  
\*  
Merlin/Main/Languages/Ruby/Libraries.LCA\_RESTRICTED/Builtins/Marshal.cs[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-6](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-6)  
\*  
Merlin/Main/Languages/Ruby/Scripts/bin/igem.bat[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-7](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-7)  
\*  
Merlin/Main/Languages/Ruby/Scripts/bin/iirb.bat[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-8](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-8)  
\*  
Merlin/Main/Languages/Ruby/Scripts/bin/irails.bat[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-9](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-9)  
\*  
Merlin/Main/Languages/Ruby/Scripts/bin/irake.bat[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-10](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-10)  
\*  
Merlin/Main/Languages/Ruby/Scripts/bin/irdoc.bat[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-11](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-11)  
\*  
Merlin/Main/Languages/Ruby/Scripts/bin/iri.bat[http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-12](http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-12)

Thanks,  
Shri