# Review: Fix

**URL:** <https://www.ruby-forum.com/t/review-fix/179118>\
**Category:** IronRuby\
**Created:** [November 18, 2009, 1:04am UTC](https://www.ruby-forum.com/t/review-fix/179118 "2009-11-18T01:04:47Z")\
**Posts on this page:** 2\
**Page:** 1

<div class="post-metadata">

**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\
**Post date:** [November 18, 2009, 1:04am UTC](https://www.ruby-forum.com/t/review-fix/179118/1 "2009-11-18T01:04:47Z")

</div>

fpt review /shelveset:regex;sborde

Implements Kernel.srand with no parameters  
Changes RubyRegex to not clone the input string when being used for  
String#scan, and to share the cloned string when possible. Without the  
sharing, you could cause OutOfMemoryException.

---

<div class="post-metadata">

**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\
**Post date:** [November 18, 2009, 1:45am UTC](https://www.ruby-forum.com/t/review-fix/179118/2 "2009-11-18T01:45:45Z")

</div>

Looks good.

Tomas

From: Shri B.  
Sent: Tuesday, November 17, 2009 3:59 PM  
To: removed\_email\_address@domain.invalid  
Cc: IronRuby External Code R.  
Subject: Review: Fix

fpt review /shelveset:regex;sborde

Implements Kernel.srand with no parameters  
Changes RubyRegex to not clone the input string when being used for  
String#scan, and to share the cloned string when possible. Without the  
sharing, you could cause OutOfMemoryException.