# Review: File.chmod **URL:** \ **Category:** IronRuby\ **Created:** [April 3, 2009, 8:35pm UTC](https://www.ruby-forum.com/t/review-file-chmod/164670 "2009-04-03T20:35:56Z")\ **Posts on this page:** 4\ **Page:** 1
**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\ **Post date:** [April 3, 2009, 8:35pm UTC](https://www.ruby-forum.com/t/review-file-chmod/164670/1 "2009-04-03T20:35:56Z")
> > > File.readable? should return false if the given filename does not exist > File.del…ete should be able to delete a read-only file. This is implemented by making the file writable first. This is the only solution I could find. > Added debugger visualizer for RubyObject so that VS will display the result of to\_s in the Watch window. > Adds the wrapper script Merlin\\Main\\Test\\Scritps\\ir.cmd so that the Legacy tests (Ruby\\Scripts\\test.bat) can pass without any failures. GitDiff.bat c71e026eca1134d77a87bd792b1d93c60e32bf81 9fc3048beb4a315ec7ac3dc82908da8f92bf1a07 - ``` Implements File.chmod ``` - ``` File.readable? should return false if the given filename does ``` not exist - ``` File.delete should be able to delete a read-only file. This is ``` implemented by making the file writable first. This is the only solution I could find. - ``` Added debugger visualizer for RubyObject so that VS will ``` display the result of to\_s in the Watch window. - ``` Adds the wrapper script Merlin\Main\Test\Scritps\ir.cmd so ``` that the Legacy tests (Ruby\Scripts\test.bat) can pass without any failures. Files changed: - Merlin/External/Languages/IronRuby/mspec/ironruby-tags/core/file/chmod\_tags.txt[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-0](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-0) \* Merlin/External/Languages/IronRuby/mspec/rubyspec/core/file/chmod\_spec.rb[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-1](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-1) \* Merlin/External/Languages/IronRuby/mspec/rubyspec/core/file/shared/unlink.rb[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-2](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-2) \* Merlin/External/Languages/IronRuby/mspec/rubyspec/library/zlib/gzipfile/comment\_spec.rb[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-3](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-3) \* Merlin/External/Languages/IronRuby/mspec/rubyspec/library/zlib/gzipfile/orig\_name\_spec.rb[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-4](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-4) \* Merlin/External/Languages/IronRuby/mspec/rubyspec/spec\_helper.rb[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-5](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-5) \* Merlin/Main/Languages/Ruby/Libraries.LCA\_RESTRICTED/Builtins/FileOps.cs[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-6](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-6) \* Merlin/Main/Languages/Ruby/Libraries.LCA\_RESTRICTED/Initializers.Generated.cs[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-7](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-7) \* Merlin/Main/Languages/Ruby/Libraries.LCA\_RESTRICTED/Zlib/zlib.cs[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-8](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-8) \* Merlin/Main/Languages/Ruby/Ruby/Builtins/RubyObject.cs[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-9](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-9) \* Merlin/Main/Test/Scripts/ir.cmd[http://github.com/shri/ironruby/tree/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07/Merlin/Main/Test/Scripts/ir.cmd](http://github.com/shri/ironruby/tree/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07/Merlin/Main/Test/Scripts/ir.cmd) Thanks, Shri ---
**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\ **Post date:** [April 3, 2009, 9:24pm UTC](https://www.ruby-forum.com/t/review-file-chmod/164670/2 "2009-04-03T21:24:34Z")
You can use RubyContext.Inspect in the DebugView. Other than that code changes look good. Tomas From: Curt H. Sent: Friday, April 03, 2009 10:53 AM To: Shri B.; IronRuby External Code R. Cc: removed\_email\_address@domain.invalid Subject: RE: Review: File.chmod The comment “// TODO: implement this correctly for windows” could probably be removed; it’s hard to envision chmod doing anything differently under Windows than what you’ve already implemented. From: Shri B. Sent: Friday, April 03, 2009 10:42 AM To: IronRuby External Code R. Cc: removed\_email\_address@domain.invalid Subject: Review: File.chmod > > > File.readable? should return false if the given filename does not exist > File.del…ete should be able to delete a read-only file. This is implemented by making the file writable first. This is the only solution I could find. > Added debugger visualizer for RubyObject so that VS will display the result of to\_s in the Watch window. > Adds the wrapper script Merlin\\Main\\Test\\Scritps\\ir.cmd so that the Legacy tests (Ruby\\Scripts\\test.bat) can pass without any failures. GitDiff.bat c71e026eca1134d77a87bd792b1d93c60e32bf81 9fc3048beb4a315ec7ac3dc82908da8f92bf1a07 - ``` Implements File.chmod ``` - ``` File.readable? should return false if the given filename does ``` not exist - ``` File.delete should be able to delete a read-only file. This is ``` implemented by making the file writable first. This is the only solution I could find. - ``` Added debugger visualizer for RubyObject so that VS will ``` display the result of to\_s in the Watch window. - ``` Adds the wrapper script Merlin\Main\Test\Scritps\ir.cmd so ``` that the Legacy tests (Ruby\Scripts\test.bat) can pass without any failures. Files changed: - Merlin/External/Languages/IronRuby/mspec/ironruby-tags/core/file/chmod\_tags.txt[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-0](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-0) \* Merlin/External/Languages/IronRuby/mspec/rubyspec/core/file/chmod\_spec.rb[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-1](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-1) \* Merlin/External/Languages/IronRuby/mspec/rubyspec/core/file/shared/unlink.rb[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-2](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-2) \* Merlin/External/Languages/IronRuby/mspec/rubyspec/library/zlib/gzipfile/comment\_spec.rb[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-3](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-3) \* Merlin/External/Languages/IronRuby/mspec/rubyspec/library/zlib/gzipfile/orig\_name\_spec.rb[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-4](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-4) \* Merlin/External/Languages/IronRuby/mspec/rubyspec/spec\_helper.rb[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-5](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-5) \* Merlin/Main/Languages/Ruby/Libraries.LCA\_RESTRICTED/Builtins/FileOps.cs[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-6](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-6) \* Merlin/Main/Languages/Ruby/Libraries.LCA\_RESTRICTED/Initializers.Generated.cs[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-7](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-7) \* Merlin/Main/Languages/Ruby/Libraries.LCA\_RESTRICTED/Zlib/zlib.cs[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-8](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-8) \* Merlin/Main/Languages/Ruby/Ruby/Builtins/RubyObject.cs[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-9](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-9) \* Merlin/Main/Test/Scripts/ir.cmd[http://github.com/shri/ironruby/tree/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07/Merlin/Main/Test/Scripts/ir.cmd](http://github.com/shri/ironruby/tree/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07/Merlin/Main/Test/Scripts/ir.cmd) Thanks, Shri ---
**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\ **Post date:** [April 3, 2009, 10:53pm UTC](https://www.ruby-forum.com/t/review-file-chmod/164670/3 "2009-04-03T22:53:34Z")
Test looks good. JD From: Tomas M. Sent: Friday, April 03, 2009 11:00 AM To: Curt H.; Shri B.; IronRuby External Code R. Cc: removed\_email\_address@domain.invalid Subject: RE: Review: File.chmod You can use RubyContext.Inspect in the DebugView. Other than that code changes look good. Tomas From: Curt H. Sent: Friday, April 03, 2009 10:53 AM To: Shri B.; IronRuby External Code R. Cc: removed\_email\_address@domain.invalid Subject: RE: Review: File.chmod The comment “// TODO: implement this correctly for windows” could probably be removed; it’s hard to envision chmod doing anything differently under Windows than what you’ve already implemented. From: Shri B. Sent: Friday, April 03, 2009 10:42 AM To: IronRuby External Code R. Cc: removed\_email\_address@domain.invalid Subject: Review: File.chmod > > > File.readable? should return false if the given filename does not exist > File.del…ete should be able to delete a read-only file. This is implemented by making the file writable first. This is the only solution I could find. > Added debugger visualizer for RubyObject so that VS will display the result of to\_s in the Watch window. > Adds the wrapper script Merlin\\Main\\Test\\Scritps\\ir.cmd so that the Legacy tests (Ruby\\Scripts\\test.bat) can pass without any failures. GitDiff.bat c71e026eca1134d77a87bd792b1d93c60e32bf81 9fc3048beb4a315ec7ac3dc82908da8f92bf1a07 - ``` Implements File.chmod ``` - ``` File.readable? should return false if the given filename does ``` not exist - ``` File.delete should be able to delete a read-only file. This is ``` implemented by making the file writable first. This is the only solution I could find. - ``` Added debugger visualizer for RubyObject so that VS will ``` display the result of to\_s in the Watch window. - ``` Adds the wrapper script Merlin\Main\Test\Scritps\ir.cmd so ``` that the Legacy tests (Ruby\Scripts\test.bat) can pass without any failures. Files changed: - Merlin/External/Languages/IronRuby/mspec/ironruby-tags/core/file/chmod\_tags.txt[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-0](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-0) \* Merlin/External/Languages/IronRuby/mspec/rubyspec/core/file/chmod\_spec.rb[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-1](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-1) \* Merlin/External/Languages/IronRuby/mspec/rubyspec/core/file/shared/unlink.rb[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-2](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-2) \* Merlin/External/Languages/IronRuby/mspec/rubyspec/library/zlib/gzipfile/comment\_spec.rb[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-3](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-3) \* Merlin/External/Languages/IronRuby/mspec/rubyspec/library/zlib/gzipfile/orig\_name\_spec.rb[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-4](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-4) \* Merlin/External/Languages/IronRuby/mspec/rubyspec/spec\_helper.rb[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-5](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-5) \* Merlin/Main/Languages/Ruby/Libraries.LCA\_RESTRICTED/Builtins/FileOps.cs[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-6](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-6) \* Merlin/Main/Languages/Ruby/Libraries.LCA\_RESTRICTED/Initializers.Generated.cs[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-7](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-7) \* Merlin/Main/Languages/Ruby/Libraries.LCA\_RESTRICTED/Zlib/zlib.cs[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-8](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-8) \* Merlin/Main/Languages/Ruby/Ruby/Builtins/RubyObject.cs[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-9](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-9) \* Merlin/Main/Test/Scripts/ir.cmd[http://github.com/shri/ironruby/tree/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07/Merlin/Main/Test/Scripts/ir.cmd](http://github.com/shri/ironruby/tree/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07/Merlin/Main/Test/Scripts/ir.cmd) Thanks, Shri ---
**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\ **Post date:** [April 3, 2009, 8:41pm UTC](https://www.ruby-forum.com/t/review-file-chmod/164670/4 "2009-04-03T20:41:48Z")
The comment “// TODO: implement this correctly for windows” could probably be removed; it’s hard to envision chmod doing anything differently under Windows than what you’ve already implemented. From: Shri B. Sent: Friday, April 03, 2009 10:42 AM To: IronRuby External Code R. Cc: removed\_email\_address@domain.invalid Subject: Review: File.chmod > > > File.readable? should return false if the given filename does not exist > File.del…ete should be able to delete a read-only file. This is implemented by making the file writable first. This is the only solution I could find. > Added debugger visualizer for RubyObject so that VS will display the result of to\_s in the Watch window. > Adds the wrapper script Merlin\\Main\\Test\\Scritps\\ir.cmd so that the Legacy tests (Ruby\\Scripts\\test.bat) can pass without any failures. GitDiff.bat c71e026eca1134d77a87bd792b1d93c60e32bf81 9fc3048beb4a315ec7ac3dc82908da8f92bf1a07 - ``` Implements File.chmod ``` - ``` File.readable? should return false if the given filename does ``` not exist - ``` File.delete should be able to delete a read-only file. This is ``` implemented by making the file writable first. This is the only solution I could find. - ``` Added debugger visualizer for RubyObject so that VS will ``` display the result of to\_s in the Watch window. - ``` Adds the wrapper script Merlin\Main\Test\Scritps\ir.cmd so ``` that the Legacy tests (Ruby\Scripts\test.bat) can pass without any failures. Files changed: - Merlin/External/Languages/IronRuby/mspec/ironruby-tags/core/file/chmod\_tags.txt[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-0](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-0) \* Merlin/External/Languages/IronRuby/mspec/rubyspec/core/file/chmod\_spec.rb[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-1](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-1) \* Merlin/External/Languages/IronRuby/mspec/rubyspec/core/file/shared/unlink.rb[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-2](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-2) \* Merlin/External/Languages/IronRuby/mspec/rubyspec/library/zlib/gzipfile/comment\_spec.rb[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-3](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-3) \* Merlin/External/Languages/IronRuby/mspec/rubyspec/library/zlib/gzipfile/orig\_name\_spec.rb[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-4](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-4) \* Merlin/External/Languages/IronRuby/mspec/rubyspec/spec\_helper.rb[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-5](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-5) \* Merlin/Main/Languages/Ruby/Libraries.LCA\_RESTRICTED/Builtins/FileOps.cs[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-6](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-6) \* Merlin/Main/Languages/Ruby/Libraries.LCA\_RESTRICTED/Initializers.Generated.cs[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-7](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-7) \* Merlin/Main/Languages/Ruby/Libraries.LCA\_RESTRICTED/Zlib/zlib.cs[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-8](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-8) \* Merlin/Main/Languages/Ruby/Ruby/Builtins/RubyObject.cs[http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-9](http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07#diff-9) \* Merlin/Main/Test/Scripts/ir.cmd[http://github.com/shri/ironruby/tree/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07/Merlin/Main/Test/Scripts/ir.cmd](http://github.com/shri/ironruby/tree/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07/Merlin/Main/Test/Scripts/ir.cmd) Thanks, Shri