# Re: Code Review: warning2

**URL:** <https://www.ruby-forum.com/t/re-code-review-warning2/145939>\
**Category:** IronRuby\
**Created:** [August 15, 2008, 9:16am UTC](https://www.ruby-forum.com/t/re-code-review-warning2/145939 "2008-08-15T09:16:17Z")\
**Posts on this page:** 3\
**Page:** 1

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [August 15, 2008, 9:16am UTC](https://www.ruby-forum.com/t/re-code-review-warning2/145939/1 "2008-08-15T09:16:17Z")

</div>

I’ll reply to both patches with this mail.

We actually can’t accept patches to anything in the DLR and Ruby parser  
and runtime. So really the patches have to be to the libraries, or the  
infrastructure. We also need to back out some of your commits. I can ask  
the DLR to make these changes for you though.

Sorry about this. We can try to make it clearer if you have a suggestion  
on how to do it.

---

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [August 15, 2008, 1:57pm UTC](https://www.ruby-forum.com/t/re-code-review-warning2/145939/2 "2008-08-15T13:57:12Z")

</div>

2008/8/15 Jim D. [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid):

> We actually can’t accept patches to anything in the DLR and Ruby parser and runtime. So really the patches have to be to the libraries, or the infrastructure. We also need to back out some of your commits. I can ask the DLR to make these changes for you though.

If this were any other project, by this time, I would have said “I  
quit. You suck. This is not open source”.

I do understand this is not any other project, but I am sad.

---

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [August 15, 2008, 3:00pm UTC](https://www.ruby-forum.com/t/re-code-review-warning2/145939/3 "2008-08-15T15:00:00Z")

</div>

“Baby steps.” Don’t think of it as just contributing to a project;  
think of it as helping to change a large multinational corporation in a  
way that benefits both it and the rest of the world.