# Re: Code Review: partial1

**URL:** <https://www.ruby-forum.com/t/re-code-review-partial1/141530>\
**Category:** IronRuby\
**Created:** [June 26, 2008, 7:59pm UTC](https://www.ruby-forum.com/t/re-code-review-partial1/141530 "2008-06-26T19:59:11Z")\
**Posts on this page:** 4\
**Page:** 1

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [June 26, 2008, 7:59pm UTC](https://www.ruby-forum.com/t/re-code-review-partial1/141530/1 "2008-06-26T19:59:11Z")

</div>

Fixed. Try again.

JD

---

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [June 26, 2008, 8:12pm UTC](https://www.ruby-forum.com/t/re-code-review-partial1/141530/2 "2008-06-26T20:12:07Z")

</div>

Looks good. Make sure that the generic test won’t timeout since the  
running time has effectively doubled. Also, in the batch file, you could  
use pushd %ROWAN\_BIN% and then popd instead of storing CURRENT.

---

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [June 26, 2008, 10:23pm UTC](https://www.ruby-forum.com/t/re-code-review-partial1/141530/3 "2008-06-26T22:23:35Z")

</div>

What’s the timeout for generic tests? Is it the one in the test? Or does  
Snap have a limit?

JD

---

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [June 26, 2008, 10:27pm UTC](https://www.ruby-forum.com/t/re-code-review-partial1/141530/4 "2008-06-26T22:27:06Z")

</div>

It’s the one in the test. There is a snap timeout as well but that is  
the for the entire task. That shouldn’t have to change.