# Re: Code Review: Fixes for File.dirname

**URL:** <https://www.ruby-forum.com/t/re-code-review-fixes-for-file-dirname/165323>\
**Category:** IronRuby\
**Created:** [April 12, 2009, 10:00am UTC](https://www.ruby-forum.com/t/re-code-review-fixes-for-file-dirname/165323 "2009-04-12T10:00:15Z")\
**Posts on this page:** 2\
**Page:** 1

<div class="post-metadata">

**Author:** ![jsoho](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/j/8baadc/32.png) [@jsoho](https://www.ruby-forum.com/u/jsoho)\
**Post date:** [April 12, 2009, 10:00am UTC](https://www.ruby-forum.com/t/re-code-review-fixes-for-file-dirname/165323/1 "2009-04-12T10:00:15Z")

</div>

And now with the actual review link =P

[http://github.com/jschementi/ironruby/commit/689aeec6046bc8ba76016f6dfa1bd947e8e3ce15](http://github.com/jschementi/ironruby/commit/689aeec6046bc8ba76016f6dfa1bd947e8e3ce15)

From: Jimmy S.  
Sent: Sunday, April 12, 2009 12:56 AM  
To: removed\_email\_address@domain.invalid  
Cc: IronRuby External Code R.  
Subject: Code Review: Fixes for File.dirname

Fixes for File.dirname; makes all core/file/dirname specs pass. For  
Rails to find log/development.log during startup.

Fixes [http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=499](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=499)

---

<div class="post-metadata">

**Author:** ![jsoho](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/j/8baadc/32.png) [@jsoho](https://www.ruby-forum.com/u/jsoho)\
**Post date:** [April 14, 2009, 9:15pm UTC](https://www.ruby-forum.com/t/re-code-review-fixes-for-file-dirname/165323/2 "2009-04-14T21:15:46Z")

</div>

Looks good.

From: Jimmy S.  
Sent: Sunday, April 12, 2009 12:59 AM  
To: removed\_email\_address@domain.invalid  
Cc: IronRuby External Code R.  
Subject: RE: Code Review: Fixes for File.dirname

And now with the actual review link =P

[http://github.com/jschementi/ironruby/commit/689aeec6046bc8ba76016f6dfa1bd947e8e3ce15](http://github.com/jschementi/ironruby/commit/689aeec6046bc8ba76016f6dfa1bd947e8e3ce15)

From: Jimmy S.  
Sent: Sunday, April 12, 2009 12:56 AM  
To: removed\_email\_address@domain.invalid  
Cc: IronRuby External Code R.  
Subject: Code Review: Fixes for File.dirname

Fixes for File.dirname; makes all core/file/dirname specs pass. For  
Rails to find log/development.log during startup.

Fixes [http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=499](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=499)