# Pull request #31 - fix workitem 6345, implemented IO#binread

**URL:** <https://www.ruby-forum.com/t/pull-request-31-fix-workitem-6345-implemented-io-binread/210416>\
**Category:** IronRuby\
**Created:** [August 8, 2011, 1:42am UTC](https://www.ruby-forum.com/t/pull-request-31-fix-workitem-6345-implemented-io-binread/210416 "2011-08-08T01:42:29Z")\
**Posts on this page:** 3\
**Page:** 1

<div class="post-metadata">

**Author:** ![dubstep](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/d/cdc98d/32.png) [@dubstep](https://www.ruby-forum.com/u/dubstep)\
**Post date:** [August 8, 2011, 1:42am UTC](https://www.ruby-forum.com/t/pull-request-31-fix-workitem-6345-implemented-io-binread/210416/1 "2011-08-08T01:42:29Z")

</div>

The pull request #31 ( [wi #6345 added IO#binread by enricosada · Pull Request #31 · IronLanguages/main · GitHub](https://github.com/IronLanguages/main/pull/31) )  
is for resolve workitem 6345 (  
[http://ironruby.codeplex.com/workitem/6345](http://ironruby.codeplex.com/workitem/6345) ).

Implemented IO#binread with rubyspec (sent also to rubyspec/rubyspec).

This anyway is not enough for fix rdoc, needed for gem install.

C:\repo\IronLanguages\>igem install rake  
Successfully installed rake-0.9.2  
1 gem installed  
Installing ri documentation for rake-0.9.2…  
C:/repo/IronLanguages/Languages/Ruby/StdLib/ruby/1.9.1/rdoc/text.rb:12:in  
`expan d_tabs': parsing "^(.{8}*?)([\x00-?-[\\t\\r\\n]]{0,7})\\t" - Nested quantifier * . (SyntaxError) from C:/repo/IronLanguages/Languages/Ruby/StdLib/ruby/1.9.1/rdoc/text.rb :9:in `lines’  
from  
C:/repo/IronLanguages/Languages/Ruby/StdLib/ruby/1.9.1/rdoc/text.rb  
:9:in `expand_tabs' from C:/repo/IronLanguages/Languages/Ruby/StdLib/ruby/1.9.1/rdoc/text.rb :60:in `normalize\_comment’  
from  
C:/repo/IronLanguages/Languages/Ruby/StdLib/ruby/1.9.1/rdoc/code\_ob  
ject.rb:97:in `comment=' from C:/repo/IronLanguages/Languages/Ruby/StdLib/ruby/1.9.1/rdoc/rdoc.rb :278:in `parse\_file’  
from  
C:/repo/IronLanguages/Languages/Ruby/StdLib/ruby/1.9.1/rdoc/rdoc.rb  
:322:in `parse\_files’

i think the problem is .{8}\*? , (like

> <https://stackoverflow.com/questions/210206/what-is-a-nested-quantifier-and-why-is-it-causing-my-regex-to-fail>

) i will check it later, probably an rdoc modify is needed, dont know  
how to fix it ironruby side.

---

<div class="post-metadata">

**Author:** ![estro](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/e/838e76/32.png) [@estro](https://www.ruby-forum.com/u/estro)\
**Post date:** [August 8, 2011, 6:37am UTC](https://www.ruby-forum.com/t/pull-request-31-fix-workitem-6345-implemented-io-binread/210416/2 "2011-08-08T06:37:31Z")

</div>

I can take a look at fixing the regex issue perhaps next weekend.

Tomas

---

<div class="post-metadata">

**Author:** ![estro](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/e/838e76/32.png) [@estro](https://www.ruby-forum.com/u/estro)\
**Post date:** [August 14, 2011, 10:16pm UTC](https://www.ruby-forum.com/t/pull-request-31-fix-workitem-6345-implemented-io-binread/210416/3 "2011-08-14T22:16:42Z")

</div>

Regex should be fixed now.
