# Potential patch (login\_engine)

**URL:** <https://www.ruby-forum.com/t/potential-patch-login-engine/56684>\
**Category:** Engines\
**Created:** [April 2, 2006, 9:43pm UTC](https://www.ruby-forum.com/t/potential-patch-login-engine/56684 "2006-04-02T21:43:22Z")\
**Posts on this page:** 2\
**Page:** 1

<div class="post-metadata">

**Author:** ![crucoba](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/c/e8c25b/32.png) [@crucoba](https://www.ruby-forum.com/u/crucoba)\
**Post date:** [April 2, 2006, 9:43pm UTC](https://www.ruby-forum.com/t/potential-patch-login-engine/56684/1 "2006-04-02T21:43:22Z")

</div>

login\_engine is good. But there are two things about that I “dislike”.  
I’ve  
been thinking of develop a patch for them, but I’d like some sense that  
the  
patch goals are agreed with, and thus making it likely to be accepted?

1. Sending out the password in email is just plain bad. I know I can  
probably  
replace the view, but I’d rather see it as an configuration option.

2. When a password is forgotten, a secondary authentication token is  
email to  
the user. As near as I can tell, that authentication token does general  
authentication, until it expires. I much prefer a model where that  
token is  
necessary to change the password, and that’s all it is good for. And  
when  
the password is changed the token is invalidated.

Should I make patch, or just fork it?

David

---

<div class="post-metadata">

**Author:** ![crucoba](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/c/e8c25b/32.png) [@crucoba](https://www.ruby-forum.com/u/crucoba)\
**Post date:** [April 3, 2006, 2:17am UTC](https://www.ruby-forum.com/t/potential-patch-login-engine/56684/2 "2006-04-03T02:17:50Z")

</div>

I’d say submit a patch. These both sound like great ideas.

-Nb

On 4/2/06 11:39 AM, “David C.” [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) wrote:

> necessary to change the password, and that’s all it is good for. And when  
> the password is changed the token is invalidated.
> 
> Should I make patch, or just fork it?
> 
> David
> 
> * * *
> 
> engine-users mailing list  
> removed\_email\_address@domain.invalid  
> [http://lists.rails-engines.org/listinfo.cgi/engine-users-rails-engines.org](http://lists.rails-engines.org/listinfo.cgi/engine-users-rails-engines.org)

```auto
Nathaniel S. H. Brown http://nshb.net

```