# Patch.spdy-55\_1.3.11 broken?

**URL:** <https://www.ruby-forum.com/t/patch-spdy-55-1-3-11-broken/229512>\
**Category:** NGINX\
**Created:** [January 14, 2013, 5:06pm UTC](https://www.ruby-forum.com/t/patch-spdy-55-1-3-11-broken/229512 "2013-01-14T17:06:56Z")\
**Posts on this page:** 7\
**Page:** 1

<div class="post-metadata">

**Author:** ![casper\_the\_ghost](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/c/58956e/32.png) [@casper\_the\_ghost](https://www.ruby-forum.com/u/casper_the_ghost)\
**Post date:** [January 14, 2013, 5:06pm UTC](https://www.ruby-forum.com/t/patch-spdy-55-1-3-11-broken/229512/1 "2013-01-14T17:06:56Z")

</div>

I have patched the nginx sources with the latest spdy patch:

/usr/src/nginx-1.3.11# patch -p1 \< patch.spdy-55\_1.3.11.txt

but building the package isn’t possible anymore:

dpkg-buildpackage -rfakeroot -uc -b  
…  
gcc -c -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat  
-Wformat-security -I src/core -I src/event -I src/event/modules -I  
src/os/unix -I objs -I src/http -I src/http/modules   
-o objs/src/http/ngx\_http\_write\_filter\_module.o   
src/http/ngx\_http\_write\_filter\_module.c  
gcc -c -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat  
-Wformat-security -I src/core -I src/event -I src/event/modules -I  
src/os/unix -I objs -I src/http -I src/http/modules   
-o objs/src/http/ngx\_http\_copy\_filter\_module.o   
src/http/ngx\_http\_copy\_filter\_module.c  
gcc -c -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat  
-Wformat-security -I src/core -I src/event -I src/event/modules -I  
src/os/unix -I objs -I src/http -I src/http/modules   
-o objs/src/http/modules/ngx\_http\_log\_module.o   
src/http/modules/ngx\_http\_log\_module.c  
gcc -c -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat  
-Wformat-security -I src/core -I src/event -I src/event/modules -I  
src/os/unix -I objs -I src/http -I src/http/modules   
-o objs/src/http/ngx\_http\_request\_body.o   
src/http/ngx\_http\_request\_body.c  
src/http/ngx\_http\_request\_body.c: In function  
‘ngx\_http\_discard\_request\_body’:  
src/http/ngx\_http\_request\_body.c:479:10: error: ‘ngx\_http\_request\_t’ has  
no  
member named ‘spdy\_stream’  
make[3]: \*\*\* [objs/src/http/ngx\_http\_request\_body.o] Error 1  
make[3]: Leaving directory `/usr/src/nginx-1.3.11' make[2]: *** [build] Error 2 make[2]: Leaving directory `/usr/src/nginx-1.3.11’  
dh\_auto\_build: make -j1 returned exit code 2  
make[1]: \*\*\* [override\_dh\_auto\_build] Error 2  
make[1]: Leaving directory `/usr/src/nginx-1.3.11’  
make: \*\*\* [build] Error 2  
dpkg-buildpackage: error: debian/rules build gave error exit status 2

Posted at Nginx Forum:

> **[patch.spdy-55\_1.3.11 broken?](https://forum.nginx.org/read.php?2,235059,235059#msg-235059)**
>
> I have patched the nginx sources with the latest spdy patch: /usr/src/nginx-1.3.11# patch -p1 \< patch.spdy-55\_1.3.11.txt but building the package isn't possible anymore: dpkg-buildpackage -rfakeroot -uc -b ... gcc -c -g -O2 -fstack-protec

---

<div class="post-metadata">

**Author:** ![casper\_the\_ghost](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/c/58956e/32.png) [@casper\_the\_ghost](https://www.ruby-forum.com/u/casper_the_ghost)\
**Post date:** [January 14, 2013, 5:54pm UTC](https://www.ruby-forum.com/t/patch-spdy-55-1-3-11-broken/229512/2 "2013-01-14T17:54:15Z")

</div>

On Monday 14 January 2013 20:06:25 philipp wrote:

> I have patched the nginx sources with the latest spdy patch:
> 
> /usr/src/nginx-1.3.11# patch -p1 \< patch.spdy-55\_1.3.11.txt
> 
> but building the package isn’t possible anymore:

Yeap, fixed.

Also, please note, the “–with-http\_spdy\_module” сonfigure option is now  
mandatory for SPDY.

See:  
[http://nginx.org/patches/spdy/CHANGES.txt](http://nginx.org/patches/spdy/CHANGES.txt)  
[http://nginx.org/patches/spdy/README.txt](http://nginx.org/patches/spdy/README.txt)

wbr, Valentin V. Bartenev

> ```
> -o objs/src/http/ngx_http_copy_filter_module.o \
> src/http/ngx_http_request_body.c
> 
> ```
> 
> make[1]: Leaving directory `/usr/src/nginx-1.3.11’  
> make: \*\*\* [build] Error 2  
> dpkg-buildpackage: error: debian/rules build gave error exit status 2

Yeap, thatls

---

<div class="post-metadata">

**Author:** ![casper\_the\_ghost](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/c/58956e/32.png) [@casper\_the\_ghost](https://www.ruby-forum.com/u/casper_the_ghost)\
**Post date:** [January 16, 2013, 11:39pm UTC](https://www.ruby-forum.com/t/patch-spdy-55-1-3-11-broken/229512/3 "2013-01-16T23:39:22Z")

</div>

> > > > > “VVB” == Valentin V Bartenev [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) writes:

VVB\> Yeap, fixed.

The patch at:

[http://nginx.org/patches/spdy/patch.spdy-58\_1.3.11.txt](http://nginx.org/patches/spdy/patch.spdy-58_1.3.11.txt)

fails to apply to nginx-1.3.11 with 37 FAILs and 143 succeeds, 22 of  
which need fuzz.

## -JimC

James C. [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) OpenPGP: 1024D/ED7DAEA6

---

<div class="post-metadata">

**Author:** ![casper\_the\_ghost](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/c/58956e/32.png) [@casper\_the\_ghost](https://www.ruby-forum.com/u/casper_the_ghost)\
**Post date:** [January 17, 2013, 11:04am UTC](https://www.ruby-forum.com/t/patch-spdy-55-1-3-11-broken/229512/4 "2013-01-17T11:04:09Z")

</div>

Hi James,

On 1/17/13 2:16 AM, James C. wrote:

> 

The following script works for me on FreeBSD box:

fetch -o- [http://www.nginx.org/download/nginx-1.3.11.tar.gz](http://www.nginx.org/download/nginx-1.3.11.tar.gz) | tar  
zxvf - && fetch  
[http://nginx.org/patches/spdy/patch.spdy-58\_1.3.11.txt](http://nginx.org/patches/spdy/patch.spdy-58_1.3.11.txt) && cd  
nginx-1.3.11 && patch -p1 \<../patch.spdy-58\_1.3.11.txt

Please note that ‘patch -C’ could produce the (false) errors you  
describe.

–  
Maxim K.  
+7 (910) 4293178

> **[F5 NGINX: Built for cloud-native apps. Ready for AI traffic.](https://www.f5.com/products/nginx)**
>
> Deliver modern applications with NGINX. Explore high-performance load balancing, API gateways, and web server solutions trusted by top global enterprises.

---

<div class="post-metadata">

**Author:** ![casper\_the\_ghost](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/c/58956e/32.png) [@casper\_the\_ghost](https://www.ruby-forum.com/u/casper_the_ghost)\
**Post date:** [January 17, 2013, 5:28pm UTC](https://www.ruby-forum.com/t/patch-spdy-55-1-3-11-broken/229512/5 "2013-01-17T17:28:00Z")

</div>

> > > > > “MK” == Maxim K. [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) writes:

MK\> The following script works for me on FreeBSD box:

MK\> fetch -o- [http://www.nginx.org/download/nginx-1.3.11.tar.gz](http://www.nginx.org/download/nginx-1.3.11.tar.gz) | tar  
MK\> zxvf - && fetch  
MK\> [http://nginx.org/patches/spdy/patch.spdy-58\_1.3.11.txt](http://nginx.org/patches/spdy/patch.spdy-58_1.3.11.txt) && cd  
MK\> nginx-1.3.11 && patch -p1 \<../patch.spdy-58\_1.3.11.txt

MK\> Please note that ‘patch -C’ could produce the (false) errors you  
MK\> describe.

On linux, using gnu patch, patch(1) and patch -C both tell me that -C is  
not a valid option to patch.

But I see the problem; the single patch file is a set of incremental  
patches.

Unfortunately, gentoo’s portage uses the --dry-run flag first, to  
determine which -p option is required. The earlier spdy patches worked  
with that automation, but the hg changeset does not.

I’ll post a bugz with them about that issue.

Is the hg repo with the spdy changes available anywhere?

## -JimC

James C. [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) OpenPGP: 1024D/ED7DAEA6

---

<div class="post-metadata">

**Author:** ![casper\_the\_ghost](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/c/58956e/32.png) [@casper\_the\_ghost](https://www.ruby-forum.com/u/casper_the_ghost)\
**Post date:** [January 17, 2013, 7:28pm UTC](https://www.ruby-forum.com/t/patch-spdy-55-1-3-11-broken/229512/6 "2013-01-17T19:28:22Z")

</div>

On Thursday 17 January 2013 20:18:08 James C. wrote:  
[…]

> Is the hg repo with the spdy changes available anywhere?

No, there’s not. I use mq extension to maintain these patches  
based on our mercurial mirror: [http://hg.nginx.org/](http://hg.nginx.org/)

wbr, Valentin V. Bartenev

–

> **[F5 NGINX: Built for cloud-native apps. Ready for AI traffic.](https://www.f5.com/products/nginx)**
>
> Deliver modern applications with NGINX. Explore high-performance load balancing, API gateways, and web server solutions trusted by top global enterprises.

> **[nginx: donation](http://nginx.org/en/donation.html)**

---

<div class="post-metadata">

**Author:** ![casper\_the\_ghost](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/c/58956e/32.png) [@casper\_the\_ghost](https://www.ruby-forum.com/u/casper_the_ghost)\
**Post date:** [January 17, 2013, 4:10pm UTC](https://www.ruby-forum.com/t/patch-spdy-55-1-3-11-broken/229512/7 "2013-01-17T16:10:52Z")

</div>

Yes the latest patch (58) works fine.

Posted at Nginx Forum:

> **[Re: patch.spdy-55\_1.3.11 broken?](https://forum.nginx.org/read.php?2,235059,235228#msg-235228)**
>
> I have patched the nginx sources with the latest spdy patch: /usr/src/nginx-1.3.11# patch -p1 \< patch.spdy-55\_1.3.11.txt but building the package isn't possible anymore: dpkg-buildpackage -rfakeroot -uc -b ... gcc -c -g -O2 -fstack-protec