# \[patch\] Ensure correct refcounting on Gst::ElementFactory.make

**URL:** <https://www.ruby-forum.com/t/patch-ensure-correct-refcounting-on-gst-elementfactory-make/133275>\
**Category:** Ruby-Gnome 2\
**Created:** [March 29, 2008, 5:56pm UTC](https://www.ruby-forum.com/t/patch-ensure-correct-refcounting-on-gst-elementfactory-make/133275 "2008-03-29T17:56:01Z")\
**Posts on this page:** 4\
**Page:** 1

<div class="post-metadata">

**Author:** ![sschunselaar](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/34f0e0/32.png) [@sschunselaar](https://www.ruby-forum.com/u/sschunselaar)\
**Post date:** [March 29, 2008, 5:56pm UTC](https://www.ruby-forum.com/t/patch-ensure-correct-refcounting-on-gst-elementfactory-make/133275/1 "2008-03-29T17:56:01Z")

</div>

Hi,

See patch for details. I was unsure which coding-style to use here. I  
picked  
the one already used in this file to minimize white-space diffs and  
prevent  
coding style inconsitency inside one function.

Sjoerd

---

<div class="post-metadata">

**Author:** ![sschunselaar](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/34f0e0/32.png) [@sschunselaar](https://www.ruby-forum.com/u/sschunselaar)\
**Post date:** [March 30, 2008, 12:31am UTC](https://www.ruby-forum.com/t/patch-ensure-correct-refcounting-on-gst-elementfactory-make/133275/2 "2008-03-30T00:31:47Z")

</div>

Hi,

In [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid)  
“[ruby-gnome2-devel-en] [patch] Ensure correct refcounting on  
Gst::ElementFactory.make” on Sat, 29 Mar 2008 17:55:39 +0100,  
Sjoerd S. [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) wrote:

> See patch for details. I was unsure which coding-style to use here. I picked  
> the one already used in this file to minimize white-space diffs and prevent  
> coding style inconsitency inside one function.

Use GOBJ2RVAL\_UNREF() for this.

Please fix coding-style after fix the problem.

## Thanks,

kou

---

<div class="post-metadata">

**Author:** ![sschunselaar](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/34f0e0/32.png) [@sschunselaar](https://www.ruby-forum.com/u/sschunselaar)\
**Post date:** [April 5, 2008, 6:39pm UTC](https://www.ruby-forum.com/t/patch-ensure-correct-refcounting-on-gst-elementfactory-make/133275/3 "2008-04-05T18:39:55Z")

</div>

On Sun, Mar 30, 2008 at 08:31:07AM +0900, Kouhei S. wrote:

> Use GOBJ2RVAL\_UNREF() for this.
> 
> Please fix coding-style after fix the problem.

Committed with that changed and the function in hopefully fixed  
coding-style 🙂

## Sjoerd

What is now proved was once only imagin’d.  
– William Blake

---

<div class="post-metadata">

**Author:** ![sschunselaar](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/34f0e0/32.png) [@sschunselaar](https://www.ruby-forum.com/u/sschunselaar)\
**Post date:** [April 6, 2008, 1:49am UTC](https://www.ruby-forum.com/t/patch-ensure-correct-refcounting-on-gst-elementfactory-make/133275/4 "2008-04-06T01:49:20Z")

</div>

Hi,

In [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid)  
“Re: [ruby-gnome2-devel-en] [patch] Ensure correct refcounting on  
Gst::ElementFactory.make” on Sat, 5 Apr 2008 18:39:18 +0200,  
Sjoerd S. [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) wrote:

> On Sun, Mar 30, 2008 at 08:31:07AM +0900, Kouhei S. wrote:
> 
> > Use GOBJ2RVAL\_UNREF() for this.
> > 
> > Please fix coding-style after fix the problem.
> 
> Committed with that changed and the function in hopefully fixed coding-style 🙂

I’ve fixed coding-style. Please confirm that and commit all  
your reviewed patches. You don’t need to care coding-style  
at present. I’ll fix. It seems that Ruby/GStreamer blocks  
Joachim’s work.

## Thanks,

kou