def score(dice)
total = 0
h = Hash.new(0)
dice.each {|el| h[el] += 1}
dice.each {|number, count|
if number == 1 and count == 6 then total = 2000 end
if number != 1 and count == 3 then total = total + 100 * count end
if number != 1 and count == 6 then total = 600 end
if number == 1 and (count > 3) then total = total + ( 100 + ( count -
3)) end
if number == 1 and (count < 3) then total = total + 100 * count end
if number == 5 and (count > 3) then total = total + ( 50 * (count
-3)) end
if number == 5 and (count < 3) then total = total + 50 * count end
}
return total
end
then I see this error message :
The answers you seek…
undefined method `>’ for nil:NilClass
I know I have a lot to learn.
I’m just beginning with ruby and in this moments I miss a IDE where I
can do everything step by step so I can see what went wrong.
Now refractor the if then 's and I hope I can decline it to less then 5
if then’s.
But that will be difficult.
Now refractor the if then 's and I hope I can decline it to less then 5 if
then’s.
But that will be difficult.
I think you should not structure the code this way. I think you should
loop through the counts, finding and removing sets. Something like
(pseudocode):
while there are sets of 3 ones:
remove the set from the hash (h[1] -= 3)
sum 1000 to the score
end
while there are sets of 3 any other pip count:
remove the set from the hash (h[x] -= 3)
sum 100*x to the score
end
sum 100 * (remaining number of ones)
sum 50 * (remaining number of fives)
This way, your code is more simple and robust. For example this will
also work if you throw 9 dice, while your current algorithm does not.
I try to learn ruby by following ruby koans.
But I think now it’s not a good idea.
They work with test-driven development.
So every test on koans fail but most of the times in the error message
is hidden what the right answer is.
In the end you have to use that knowlegde to solve puzzles like this.
I’m just beginning with ruby and in this moments I miss a IDE where I
can do everything step by step so I can see what went wrong.
Well, I wouldn’t rely too much on the IDE. The danger of this is that it
leads to a kind of “trial and error” programming: You just write
something down and then use the debugger to make actual working code out
of it.
That’s not how it should be, especially when you’ve just started. The
code reflects your thoughts, so it should at least be logical in itself.
Sure, we all make mistakes, so there will always be typos, syntax errors
etc. But when your code is logical incorrect, it shows that you’ve not
really thought this through (or maybe didn’t even understand the parts
you’ve copied and pasted).
This is no critique or something, just a suggestion. In school exams, we
actually have to write down our code on a piece of paper. This way we
focus on clear thoughts, not so much on getting the code running
somehow.
Now refractor the if then 's and I hope I can decline it to less then 5
if then’s.
I don’t understand the logic, so I can’t help you with that. But you
should structure the cases with nested "if"s.