Https + large-file sending, sometimes fails

GSSSSbor_Farkas · December 20, 2007, 2:22pm

On Thu, Dec 20, 2007 at 01:40:09PM +0300, Igor S. wrote:

Thank you, I have just reproduce the case.

The attached patch should fix the bug.

The complete patch.

The new commited patch.

1st, it fixes the cause of bug - SSL_shutdown() handling.
SSL_shutdown() man states incorrectly that SSL_shutdown() will return -1
on error. Actually SSL_shutdown() never returns -1.

2nd, it clears and logs possible previously unhandled SSL errors so
they have not affect on a new operation.

GSSSSbor_Farkas · December 20, 2007, 3:13pm

Igor S. wrote:

contains this patch?

0.6.23 will be next week.

hmm… but isn’t the 0.6 “series” the development series?
at least, from the website:

The last stable version is nginx-0.5.34, the change log.
The last development version is nginx-0.6.22, the change log.

which practically means, that debian does not have the 0.6 series.

so i probably will have to patch my local copy of nginx-0.5.x

p.s: are there any plans making the 0.6 series “stable”
at some point?

gabor

GSSSSbor_Farkas · December 21, 2007, 2:50am

On Thu, 2007-12-20 at 15:02 +0100, GÃ¡bor Farkas wrote:

Igor S. wrote:

0.6.23 will be next week.

hmm… but isn’t the 0.6 “series” the development series?
at least, from the website:

The last stable version is nginx-0.5.34, the change log.
The last development version is nginx-0.6.22, the change log.

You’ll also find in the FAQ that most people consider 0.6 stable enough.

I run all my servers on 0.6.x. If I were to encounter issues with a
particular 0.6.x release, I’d simply revert to whatever 0.6.x release I
was using previously.

which practically means, that debian does not have the 0.6 series.

so i probably will have to patch my local copy of nginx-0.5.x

Or upgrade to 0.6 =) Not sure that patching a 0.5 package is any easier
than installing 0.6 from source.

p.s: are there any plans making the 0.6 series “stable”
at some point?

I think that’s a question for the Debian packagers. Given Debian’s
rather conservative attitude, I wouldn’t expect much. Even were Igor to
declare 0.6 stable tomorrow, I doubt you’d see it in Debian until next
year some time.

Regards,
Cliff

GSSSSbor_Farkas · December 21, 2007, 2:58am

On Dec 20, 2007, at 6:52 AM, Igor S. wrote:

2nd, it clears and logs possible previously unhandled SSL errors
at least, from the website:

The 0.6.x is quite stable. I use it on http://www.rambler.ru, my job
main site. The features and bugfixes in 0.6.x are merged to 0.5.x
after
some time. If you will test the patch on 0.5.x, then it will be
included
in next 0.5.35 before NY or before my vacantion in January.

We are running 0.6.x here as well on 800 VM’s. It is definitely
stable enough for production. I usually track the latest releases as
gentoo has them very quickly.

Cheers-

Ezra Z.
– Founder & Software Architect
– [email protected]
– EngineYard.com

GSSSSbor_Farkas · December 21, 2007, 3:47am

For any of the OS X users out there I was thinking on the way to work
this morning I would submit an nginx-devel macports port which would
be built on the 0.6 tree and include support for stub_status and the
fair balancer.

Is their any interest in a nginx-devel 0.6 macports port?

Cheers

Dave

GSSSSbor_Farkas · December 20, 2007, 4:01pm

On Thu, Dec 20, 2007 at 03:02:10PM +0100, G??bor Farkas wrote:

regarding this one… when will there be a new version of nginx, which
which practically means, that debian does not have the 0.6 series.

so i probably will have to patch my local copy of nginx-0.5.x

p.s: are there any plans making the 0.6 series “stable”
at some point?

The 0.6.x is quite stable. I use it on http://www.rambler.ru, my job
main site. The features and bugfixes in 0.6.x are merged to 0.5.x after
some time. If you will test the patch on 0.5.x, then it will be included
in next 0.5.35 before NY or before my vacantion in January.

GSSSSbor_Farkas · December 21, 2007, 4:01am

I think this is a great idea, and am definitely interested, as long as
it would have a --with-http_perl_module variant too…

Jed

GSSSSbor_Farkas · December 21, 2007, 9:52am

Igor S. wrote:

On Thu, Dec 20, 2007 at 03:02:10PM +0100, G??bor Farkas wrote:
If you will test the patch on 0.5.x, then it will be included
in next 0.5.35 before NY or before my vacantion in January.

well, the tests i did for the patch were done on 0.5.33.

so, if you would like me to do more tests, please tell me what scenario,
and i can do it, no problem.

p.s: but of course, if you do not want to include this patch in the
0.5.x series, it’s entirely your decision. i respect that.

thanks,
gabor