We’ll make sure we review your code; if for some reason it falls through
the cracks, just ping 
Thanks,
-John
From: [email protected]
[mailto:[email protected]] On Behalf Of Peter Bacon
Darwin
Sent: Friday, October 03, 2008 11:07 AM
To: [email protected]
Subject: Re: [Ironruby-core] Compilation errors for IR SVN 154
OK so I will post the changes to this list first. What are the criteria
for the code being accepted? What if nobody replies? How long do I
wait before I commit? Etc etc etc.
Pete
From: [email protected]
[mailto:[email protected]] On Behalf Of Jim D.
Sent: Friday,03 October 03, 2008 18:45
To: [email protected]
Subject: Re: [Ironruby-core] Compilation errors for IR SVN 154
I think we all should have code review before we commit. It’s something
we do for everything here, and it would probably be useful for everyone
else.
JD
From: [email protected]
[mailto:[email protected]] On Behalf Of Peter Bacon
Darwin
Sent: Friday, October 03, 2008 10:42 AM
To: [email protected]
Subject: Re: [Ironruby-core] Compilation errors for IR SVN 154
Sorry, I should update initializers.generated.cs when I commit - I
always shied away from that when posting patches as they would need to
be regenerated anyway. By the way, should there be some kind of code
review for my commits? Should I post my proposed changes to the list
first?
Regards,
Pete
From: [email protected]
[mailto:[email protected]] On Behalf Of John L.
(IRONRUBY)
Sent: Friday,03 October 03, 2008 17:08
To: [email protected]
Subject: Re: [Ironruby-core] Compilation errors for IR SVN 154
Just committed a fix for the compilation errors.
Thanks,
-John
From: [email protected]
[mailto:[email protected]] On Behalf Of Stefan D.
Sent: Friday, October 03, 2008 8:26 AM
To: [email protected]
Subject: Re: [Ironruby-core] Compilation errors for IR SVN 154
I think this problem came from BigDecimal implementation that Peter
recently committed. Maybe \IronRuby.Libraries\Initializers.Generated.cs
should be regenerated and committed again.
You can revert to revision 152 that compiles just fine.
P.S.: When the recent changes that were posted in the list will get
committed in the public repository?
2008/10/3 Robert B.
<[email protected]mailto:[email protected]>
I am getting compilation errors in IronRuby.Libraries project with the
latest IR SVN 154 version when compiling with Visual Studio 2008:
------ Build started: Project: Microsoft.Scripting.Core, Configuration:
Debug Any CPU ------
Microsoft.Scripting.Core →
C:\programs\IronRuby\trunk\build\debug\Microsoft.Scripting.Core.dll
------ Build started: Project: Microsoft.Scripting, Configuration: Debug
Any CPU ------
Microsoft.Scripting →
C:\programs\IronRuby\trunk\build\debug\Microsoft.Scripting.dll
------ Build started: Project: Ruby, Configuration: Debug Any CPU ------
Ruby → C:\programs\IronRuby\trunk\build\debug\IronRuby.dll
------ Build started: Project: IronRuby.Libraries, Configuration: Debug
Any CPU ------
…
warning CS1685: The predefined type
‘System.Runtime.CompilerServices.ExtensionAttribute’ is defined in
multiple assemblies in the global alias; using definition from
‘c:\programs\IronRuby\trunk\build\debug\Microsoft.Scripting.dll’
C:\programs\IronRuby\trunk\src\IronRuby.Libraries\Initializers.Generated
.cs(6813,17): error CS0123: No overload for ‘Add’ matches delegate
‘System.Func<Microsoft.Scripting.Runtime.CodeContext,IronRuby.StandardLi
brary.BigDecimal.BigDecimal,object,object,object>’
c:\programs\IronRuby\trunk\build\debug\Microsoft.Scripting.Core.dll:
(Related file)
C:\programs\IronRuby\trunk\src\IronRuby.Libraries\BigDecimal\BigDecimalO
ps.cs(352,30): (Related location)
C:\programs\IronRuby\trunk\src\IronRuby.Libraries\Initializers.Generated
.cs(6822,17): error CS0123: No overload for ‘Coerce’ matches delegate
‘System.Func<Microsoft.Scripting.Runtime.CodeContext,IronRuby.StandardLi
brary.BigDecimal.BigDecimal,double,IronRuby.Builtins.RubyArray>’
c:\programs\IronRuby\trunk\build\debug\Microsoft.Scripting.Core.dll:
(Related file)
…
Compile complete – 8 errors, 1 warnings
…