# Good code?

**URL:** <https://www.ruby-forum.com/t/good-code/88487>\
**Category:** Rails\
**Created:** [March 11, 2007, 11:51pm UTC](https://www.ruby-forum.com/t/good-code/88487 "2007-03-11T23:51:07Z")\
**Posts on this page:** 1\
**Page:** 1

<div class="post-metadata">

**Author:** ![leonb](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/l/22d042/32.png) [@leonb](https://www.ruby-forum.com/u/leonb)\
**Post date:** [March 11, 2007, 11:51pm UTC](https://www.ruby-forum.com/t/good-code/88487/1 "2007-03-11T23:51:07Z")

</div>

Hi,

Could you look at some code I created? I don’t know if it’s good… or  
if it could be better.  
Especially the controller. I couldn’t find a way to let the  
declaration\_payers be automatically saved.

declarations\_controller.rb:  
def create  
@declaration = Declaration.new(params[:declaration])

```
unless @declaration.save
  @users = User.find(:all)
  render :action => 'new'
  return false
end

@declarations_payers = params[:declarations_payers]
@additional_persons = params[:additional_persons]

#If there are payers, add them
if @declarations_payers
  @declarations_payers.each_value { |user_id|

    #Add new object
    @declarations_payer = DeclarationsPayer.new

    #Set user_id variable (from post)
    @declarations_payer.user_id = user_id

    #Add aditional persons (from post)
    @declarations_payer.additional_persons =

```

@additional\_persons[user\_id]

```
    #Add the object to the declaration object
    @declaration.declarations_payers << @declarations_payer
  }
end

flash[:notice] = 'Declaration was successfully created.'
redirect_to :action => 'list'

```

end

\_form.rhtml:  
\<%= error\_messages\_for ‘declaration’ %\>

Amount  
\<%= text\_field 'declaration', 'amount' %\>

Description  
\<%= text\_field 'declaration', 'description' %\>

\<% unless @users.nil? %\>

\<% for user in @users %\> \<%= user.fullname %\>

```
<%= check_box_tag 'declarations_payers['+user.id.to_s+']',

```

user.id, @declaration.users.include?(user) %\>  
met  
\<%= text\_field\_tag ‘additional\_persons[’+user.id.to\_s+’]’,  
@declaration\_payers[user.id], ‘size’ =\> 1 %\>

```
additionele personen
<br />

```

\<% end %\>

 \<% end %\>

Thanks in advance!