# FYI Review: Jirapong's fix for Kernel.open with permissions

**URL:** <https://www.ruby-forum.com/t/fyi-review-jirapongs-fix-for-kernel-open-with-permissions/165409>\
**Category:** IronRuby\
**Created:** [April 13, 2009, 7:02pm UTC](https://www.ruby-forum.com/t/fyi-review-jirapongs-fix-for-kernel-open-with-permissions/165409 "2009-04-13T19:02:22Z")\
**Posts on this page:** 1\
**Page:** 1

<div class="post-metadata">

**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\
**Post date:** [April 13, 2009, 7:02pm UTC](https://www.ruby-forum.com/t/fyi-review-jirapongs-fix-for-kernel-open-with-permissions/165409/1 "2009-04-13T19:02:22Z")

</div>

FYI only…

[http://github.com/Jirapong/ironruby/commit/4fe87082c15101ab2af9432ef203517935e8d970](http://github.com/Jirapong/ironruby/commit/4fe87082c15101ab2af9432ef203517935e8d970)  
(Jirapong’s change)

> <https://github.com/shri-zz/ironruby/commit/5e8c6b232a3c952985adbf1b9cda5c456d503cea>

(my code review)

GitDiff.bat 870c65e53faa912030475da393569a02bc308a2b  
5e8c6b232a3c952985adbf1b9cda5c456d503cea

fix kernel.open with permission parameter

Files changed:

- 

Merlin/External.LCA\_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/kernel/open\_tags.txt[http://github.com/shri/ironruby/commit/5e8c6b232a3c952985adbf1b9cda5c456d503cea#diff-0](http://github.com/shri/ironruby/commit/5e8c6b232a3c952985adbf1b9cda5c456d503cea#diff-0)  
\*  
Merlin/External.LCA\_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/kernel/open\_spec.rb[http://github.com/shri/ironruby/commit/5e8c6b232a3c952985adbf1b9cda5c456d503cea#diff-1](http://github.com/shri/ironruby/commit/5e8c6b232a3c952985adbf1b9cda5c456d503cea#diff-1)  
\*  
Merlin/Main/Languages/Ruby/Libraries.LCA\_RESTRICTED/Builtins/FileOps.cs[http://github.com/shri/ironruby/commit/5e8c6b232a3c952985adbf1b9cda5c456d503cea#diff-2](http://github.com/shri/ironruby/commit/5e8c6b232a3c952985adbf1b9cda5c456d503cea#diff-2)  
\*  
Merlin/Main/Languages/Ruby/Libraries.LCA\_RESTRICTED/Builtins/KernelOps.cs[http://github.com/shri/ironruby/commit/5e8c6b232a3c952985adbf1b9cda5c456d503cea#diff-3](http://github.com/shri/ironruby/commit/5e8c6b232a3c952985adbf1b9cda5c456d503cea#diff-3)  
\*  
Merlin/Main/Languages/Ruby/Ruby/Runtime/Calls/ProtocolConversionAction.cs[http://github.com/shri/ironruby/commit/5e8c6b232a3c952985adbf1b9cda5c456d503cea#diff-4](http://github.com/shri/ironruby/commit/5e8c6b232a3c952985adbf1b9cda5c456d503cea#diff-4)

Thanks,  
Shri