# FYI Code Review: config **URL:** \ **Category:** IronRuby\ **Created:** [March 11, 2010, 8:42pm UTC](https://www.ruby-forum.com/t/fyi-code-review-config/185014 "2010-03-11T20:42:36Z")\ **Posts on this page:** 6\ **Page:** 1
**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\ **Post date:** [March 11, 2010, 8:42pm UTC](https://www.ruby-forum.com/t/fyi-code-review-config/185014/1 "2010-03-11T20:42:36Z")
tfpt review “/shelveset:config;REDMOND\sborde” Comment : Change RbConfig::CONFIG[“arch”] to “universal-dotnet2.0” (or “universal-dotnet4.0” on .NET 4) Also changed RbConfig::CONFIG[“host\_os”] to be based on RUBY\_PLATFORM so that it will be mswin32 on Windows and linux on Linux. Removed some config values that are not present in JRuby ---
**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\ **Post date:** [March 11, 2010, 8:54pm UTC](https://www.ruby-forum.com/t/fyi-code-review-config/185014/2 "2010-03-11T20:54:54Z")
Looks good. As part of MQ, we should look deeply at the compilation based variables and see if they can be removed or picked up from the arguments to csc. JD ---
**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\ **Post date:** [March 11, 2010, 9:17pm UTC](https://www.ruby-forum.com/t/fyi-code-review-config/185014/3 "2010-03-11T21:17:10Z")
I still have misgivings about RUBY\_PLATFORM identifying the underlying OS, when in reality, the platform that Ruby is running on is the CLR. Based on this change, I will update my patch for Ruby Gems and resubmit to that team. – Will G. [http://hotgazpacho.org/](http://hotgazpacho.org/) ---
**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\ **Post date:** [March 12, 2010, 4:12am UTC](https://www.ruby-forum.com/t/fyi-code-review-config/185014/4 "2010-03-12T04:12:13Z")
+1000 on cleaning up RbConfig. Perhaps a bost-build step that writes out rbconfig.rb? What is MQ? – Will G. [http://hotgazpacho.org/](http://hotgazpacho.org/) ---
**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\ **Post date:** [March 12, 2010, 6:58pm UTC](https://www.ruby-forum.com/t/fyi-code-review-config/185014/5 "2010-03-12T18:58:59Z")
MQ stands for quality milestone. It’s a period teams often use to pay of engineering debt. We will be doing some of that after IronRuby 1.0 ships. From: removed\_email\_address@domain.invalid [[mailto:removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid)] On Behalf Of Will G. Sent: Thursday, March 11, 2010 7:11 PM To: ironruby-core Subject: Re: [Ironruby-core] FYI Code Review: config +1000 on cleaning up RbConfig. Perhaps a bost-build step that writes out rbconfig.rb? What is MQ? – Will G. [http://hotgazpacho.org/](http://hotgazpacho.org/) On Thu, Mar 11, 2010 at 2:53 PM, Jim D. \ wrote: Looks good. As part of MQ, we should look deeply at the compilation based variables and see if they can be removed or picked up from the arguments to csc. JD ---
**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\ **Post date:** [March 12, 2010, 7:05pm UTC](https://www.ruby-forum.com/t/fyi-code-review-config/185014/6 "2010-03-12T19:05:25Z")
Watch out for leaking Microsoft-speak 😉 Sorry about that. JD From: removed\_email\_address@domain.invalid [[mailto:removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid)] On Behalf Of Shri B. Sent: Friday, March 12, 2010 9:58 AM To: removed\_email\_address@domain.invalid Subject: Re: [Ironruby-core] FYI Code Review: config MQ stands for quality milestone. It’s a period teams often use to pay of engineering debt. We will be doing some of that after IronRuby 1.0 ships. From: removed\_email\_address@domain.invalid [[mailto:removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid)] On Behalf Of Will G. Sent: Thursday, March 11, 2010 7:11 PM To: ironruby-core Subject: Re: [Ironruby-core] FYI Code Review: config +1000 on cleaning up RbConfig. Perhaps a bost-build step that writes out rbconfig.rb? What is MQ? – Will G. [http://hotgazpacho.org/](http://hotgazpacho.org/) On Thu, Mar 11, 2010 at 2:53 PM, Jim D. \ wrote: Looks good. As part of MQ, we should look deeply at the compilation based variables and see if they can be removed or picked up from the arguments to csc. JD