# FW: Can someone do a review of Pete's patch so that we can submit? **URL:** \ **Category:** IronRuby\ **Created:** [November 29, 2007, 11:14pm UTC](https://www.ruby-forum.com/t/fw-can-someone-do-a-review-of-petes-patch-so-that-we-can-submit/121687 "2007-11-29T23:14:17Z")\ **Posts on this page:** 3\ **Page:** 1
**Author:** ![John\_LSSDLR](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/j/5f8ce5/32.png) [@John\_LSSDLR](https://www.ruby-forum.com/u/John_LSSDLR)\ **Post date:** [November 29, 2007, 11:14pm UTC](https://www.ruby-forum.com/t/fw-can-someone-do-a-review-of-petes-patch-so-that-we-can-submit/121687/1 "2007-11-29T23:14:17Z")
Review from Tomas From: Tomas M. Sent: Thursday, November 29, 2007 12:32 PM To: John L. (DLR); IronRuby Team Subject: RE: Can someone do a review of Pete’s patch so that we can submit? Few issues: - ``` Fixnum.Abs is incorrect: abs(Int32.MinValue) will blow up, it ``` should overlflow to BigInteger. - ``` Why FloatOps.ToInteger doesn't just do try { return ``` (int)self; } catch (…) {…} ? Flooring is actually incorrect: (-0.4).to\_i gives 0 in Ruby while -1 in IronRuby. A test for this is apparently missing. - ``` Why FloatOps.Divmod doesn't use Math.IEEEReminder? There ``` might be some precision peculiarity involved. Tomas ---
**Author:** ![John\_LSSDLR](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/j/5f8ce5/32.png) [@John\_LSSDLR](https://www.ruby-forum.com/u/John_LSSDLR)\ **Post date:** [November 30, 2007, 9:23am UTC](https://www.ruby-forum.com/t/fw-can-someone-do-a-review-of-petes-patch-so-that-we-can-submit/121687/2 "2007-11-30T09:23:26Z")
Hi Tomas, I was only focussing on Bignum methods. The other ones in Fixnum and Float were hacked together to support getting the specs to pass. I was going to look at Fixnum and Float next. Unfortunately, due to the coercion functionality in Ruby, it is not possible to completely isolate any of the numeric types from each other to unit test. Pete From: removed\_email\_address@domain.invalid [[mailto:removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid)] On Behalf Of John L. (DLR) Sent: Thursday,29 November 29, 2007 22:13 To: removed\_email\_address@domain.invalid Subject: [Ironruby-core] FW: Can someone do a review of Pete’s patch so that we can submit? Review from Tomas From: Tomas M. Sent: Thursday, November 29, 2007 12:32 PM To: John L. (DLR); IronRuby Team Subject: RE: Can someone do a review of Pete’s patch so that we can submit? Few issues: - ``` Fixnum.Abs is incorrect: abs(Int32.MinValue) will blow up, it ``` should overlflow to BigInteger. - ``` Why FloatOps.ToInteger doesn't just do try { return ``` (int)self; } catch (.) {.} ? Flooring is actually incorrect: (-0.4).to\_i gives 0 in Ruby while -1 in IronRuby. A test for this is apparently missing. - ``` Why FloatOps.Divmod doesn't use Math.IEEEReminder? There ``` might be some precision peculiarity involved. Tomas ---
**Author:** ![John\_LSSDLR](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/j/5f8ce5/32.png) [@John\_LSSDLR](https://www.ruby-forum.com/u/John_LSSDLR)\ **Post date:** [December 1, 2007, 3:21pm UTC](https://www.ruby-forum.com/t/fw-can-someone-do-a-review-of-petes-patch-so-that-we-can-submit/121687/3 "2007-12-01T15:21:22Z")
Sorry if my last mail on this subject sounded a bit defensive. Thanks for reviewing the patch I sent in. I am really pleased that there were no serious issues with the code I wrote for the Bignum class and this gives me confidence to get on with the rest of the numeric classes. Cheers, Pete From: removed\_email\_address@domain.invalid [[mailto:removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid)] On Behalf Of John L. (DLR) Sent: Thursday,29 November 29, 2007 22:13 To: removed\_email\_address@domain.invalid Subject: [Ironruby-core] FW: Can someone do a review of Pete’s patch so that we can submit? Review from Tomas From: Tomas M. Sent: Thursday, November 29, 2007 12:32 PM To: John L. (DLR); IronRuby Team Subject: RE: Can someone do a review of Pete’s patch so that we can submit? Few issues: - ``` Fixnum.Abs is incorrect: abs(Int32.MinValue) will blow up, it ``` should overlflow to BigInteger. - ``` Why FloatOps.ToInteger doesn't just do try { return ``` (int)self; } catch (.) {.} ? Flooring is actually incorrect: (-0.4).to\_i gives 0 in Ruby while -1 in IronRuby. A test for this is apparently missing. - ``` Why FloatOps.Divmod doesn't use Math.IEEEReminder? There ``` might be some precision peculiarity involved. Tomas