# Devel policy (small issue) **URL:** \ **Category:** Ruby-Gnome 2\ **Created:** [June 18, 2006, 11:18pm UTC](https://www.ruby-forum.com/t/devel-policy-small-issue/63763 "2006-06-18T23:18:47Z")\ **Posts on this page:** 4\ **Page:** 1
**Author:** ![blueprint](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/b/cc9497/32.png) [@blueprint](https://www.ruby-forum.com/u/blueprint)\ **Post date:** [June 18, 2006, 11:18pm UTC](https://www.ruby-forum.com/t/devel-policy-small-issue/63763/1 "2006-06-18T23:18:47Z")
I have noticed in pango/src/rbpangofont.c: return c ? BOXED2RVAL(c, PANGO\_TYPE\_COVERAGE) : Qnil; but the rbgobj\_make\_boxed triggered by BOXED2RVAL already returns Qnil if the passed first argument is no true. Is it because it is older code when rbgobj\_make\_boxed didn’t do so? If so, I can propose to use a quick script[1] to “clean” all the occurrences of this. [1] I’m afraid I would write it in Perl 😕 – Guillaume C. - [http://zarb.org/~gc/](http://zarb.org/~gc/) ---
**Author:** ![blueprint](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/b/cc9497/32.png) [@blueprint](https://www.ruby-forum.com/u/blueprint)\ **Post date:** [June 20, 2006, 8:08pm UTC](https://www.ruby-forum.com/t/devel-policy-small-issue/63763/2 "2006-06-20T20:08:19Z")
Hi, On Sun, 18 Jun 2006 23:15:46 +0200 “Guillaume C.” [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) wrote: > I have noticed in pango/src/rbpangofont.c: > > return c ? BOXED2RVAL(c, PANGO\_TYPE\_COVERAGE) : Qnil; > > but the rbgobj\_make\_boxed triggered by BOXED2RVAL already returns Qnil > if the passed first argument is no true. Is it because it is older > code when rbgobj\_make\_boxed didn’t do so? Yes. There are many codes like this. e.g.) “a ? Qtrue : Qfalse” should change CBOOL2RVAL(a), too. > If so, I can propose to use > a quick script[1] to “clean” all the occurrences of this. > > [1] I’m afraid I would write it in Perl 😕 Perl ! Why!? But OK. I think you have the account of developer CVS. Could you fix them and apply it to CVS? #If you need, I’ll check your patch before you’ll commit it to CVS. – .:% Masao M.[removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) ---
**Author:** ![blueprint](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/b/cc9497/32.png) [@blueprint](https://www.ruby-forum.com/u/blueprint)\ **Post date:** [June 21, 2006, 8:37am UTC](https://www.ruby-forum.com/t/devel-policy-small-issue/63763/3 "2006-06-21T08:37:39Z")
> > [1] I’m afraid I would write it in Perl 😕 > > Perl ! Why!? Because I’m much more comfortable with Perl for one/two liners (and IMHO Perl is more convenient because more lenient - vivification of variables for example). > But OK. I think you have the account of developer CVS. > Could you fix them and apply it to CVS? Yes, I can. > #If you need, I’ll check your patch before you’ll commit it to CVS. I don’t need this but if you are more comfortable verifying first, just let me know. – Guillaume C. - [http://zarb.org/~gc/](http://zarb.org/~gc/) ---
**Author:** ![blueprint](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/b/cc9497/32.png) [@blueprint](https://www.ruby-forum.com/u/blueprint)\ **Post date:** [June 21, 2006, 5:29pm UTC](https://www.ruby-forum.com/t/devel-policy-small-issue/63763/4 "2006-06-21T17:29:30Z")
Hi, On Wed, 21 Jun 2006 08:37:15 +0200 “Guillaume C.” [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) wrote: > Yes, I can. > > > #If you need, I’ll check your patch before you’ll commit it to CVS. > > I don’t need this but if you are more comfortable verifying first, > just let me know. No problem. Apply it unless my verifying, please. – .:% Masao M.[removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid)