# Controller logic not working

**URL:** <https://www.ruby-forum.com/t/controller-logic-not-working/154454>\
**Category:** Rails\
**Created:** [November 29, 2008, 10:30pm UTC](https://www.ruby-forum.com/t/controller-logic-not-working/154454 "2008-11-29T22:30:23Z")\
**Posts on this page:** 2\
**Page:** 1

<div class="post-metadata">

**Author:** ![jsimone](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/j/2bfe46/32.png) [@jsimone](https://www.ruby-forum.com/u/jsimone)\
**Post date:** [November 29, 2008, 10:30pm UTC](https://www.ruby-forum.com/t/controller-logic-not-working/154454/1 "2008-11-29T22:30:23Z")

</div>

So I’ve written this code in my controller and it doesn’t seem to  
process my records and I don’t know why.

error = nil  
@my\_cart = @user.shopping\_cart  
@my\_cart\_items = @user.shopping\_cart.shopping\_cart\_items  
for shopping\_cart\_item in @my\_cart\_items  
if @quantity \> 0  
…do stuff  
end

end

Is this valid?

---

<div class="post-metadata">

**Author:** ![jsimone](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/j/2bfe46/32.png) [@jsimone](https://www.ruby-forum.com/u/jsimone)\
**Post date:** [November 29, 2008, 10:55pm UTC](https://www.ruby-forum.com/t/controller-logic-not-working/154454/2 "2008-11-29T22:55:53Z")

</div>

Hello–

On Nov 29, 2008, at 1:30 PM, Joe S. wrote:

> end
> 
> end
> 
> ## Is this valid?

No. This doesn’t look like it should work. I’d really recommend  
reading up on Ruby a bit. @my\_cart\_items would appear to be a  
collection (an array). Using “for” you are iterating over that list  
but you are not using the individual item yielded by the iterator. So,  
perhaps what you wanted was:

for shopping\_cart\_item in @my\_cart\_items do |item|  
unless item.quantity.zero?  
# do stuff…  
end  
end