# Code Review: VisibilityAndOtherFixes2

**URL:** <https://www.ruby-forum.com/t/code-review-visibilityandotherfixes2/153413>\
**Category:** IronRuby\
**Created:** [November 16, 2008, 10:11pm UTC](https://www.ruby-forum.com/t/code-review-visibilityandotherfixes2/153413 "2008-11-16T22:11:32Z")\
**Posts on this page:** 4\
**Page:** 1

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [November 16, 2008, 10:11pm UTC](https://www.ruby-forum.com/t/code-review-visibilityandotherfixes2/153413/1 "2008-11-16T22:11:32Z")

</div>

tfpt review “/shelveset:VisibilityAndOtherFixes2;REDMOND\tomat”  
Comment :  
Implements  
- private method visibility  
- DATA constant  
- popen and duplex IO streams (will need some refactoring of  
RubyIO object)

```
  Fixes:
  - warnings (verbosity levels, Kernel#warn)
  - Kernel#gets, print, puts (no dynamic call to IO#puts)
  - method reflection: Kernel#methods, Kernel#singleton_methods 

```

(methods were missing in some cases)  
- $~ variable scoping (should be an inner-most non-block scope)  
- inclusion of module already included in a super class was  
handled incorrectly

Tomas

---

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [November 17, 2008, 12:26am UTC](https://www.ruby-forum.com/t/code-review-visibilityandotherfixes2/153413/2 "2008-11-17T00:26:14Z")

</div>

On Sun, Nov 16, 2008 at 4:10 PM, Tomas M. \<  
removed\_email\_address@domain.invalid\> wrote:

> tfpt review “/shelveset:VisibilityAndOtherFixes2;REDMOND\tomat”  
> Comment :  
> Implements  
> - private method visibility

_drools_

---

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [November 17, 2008, 7:39pm UTC](https://www.ruby-forum.com/t/code-review-visibilityandotherfixes2/153413/3 "2008-11-17T19:39:25Z")

</div>

Changes look good.

---

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [November 17, 2008, 7:44pm UTC](https://www.ruby-forum.com/t/code-review-visibilityandotherfixes2/153413/4 "2008-11-17T19:44:42Z")

</div>

Test looks good.

JD

From: removed\_email\_address@domain.invalid  
[[mailto:removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid)] On Behalf Of Michael  
Letterle  
Sent: Sunday, November 16, 2008 3:25 PM  
To: removed\_email\_address@domain.invalid  
Cc: IronRuby External Code R.  
Subject: Re: [Ironruby-core] Code Review: VisibilityAndOtherFixes2

On Sun, Nov 16, 2008 at 4:10 PM, Tomas M.  
\<removed\_email\_address@domain.invalid[mailto:removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid)\>  
wrote:  
tfpt review “/shelveset:VisibilityAndOtherFixes2;REDMOND\tomat”  
Comment :  
Implements  
- private method visibility

_drools_