# Code Review: unniseo

**URL:** <https://www.ruby-forum.com/t/code-review-unniseo/145351>\
**Category:** IronRuby\
**Created:** [August 8, 2008, 10:24am UTC](https://www.ruby-forum.com/t/code-review-unniseo/145351 "2008-08-08T10:24:10Z")\
**Posts on this page:** 2\
**Page:** 1

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [August 8, 2008, 10:24am UTC](https://www.ruby-forum.com/t/code-review-unniseo/145351/1 "2008-08-08T10:24:10Z")

</div>

tfpt review “/shelveset:unniseo;REDMOND\jdeville”  
Comment :  
-Patch from Unni to return true for File.zero? ‘nul’ and File.zero?  
‘NUL’  
-Patch from Seo to search for both ruby and ruby.exe when searching  
for a ruby binary  
-Incorporates feedback from #ironruby IRC channel to use the first  
Ruby found instead of throwing an error when multiple are found

---

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [August 8, 2008, 6:30pm UTC](https://www.ruby-forum.com/t/code-review-unniseo/145351/2 "2008-08-08T18:30:05Z")

</div>

Change looks good.