# Code Review: unni1 **URL:** \ **Category:** IronRuby\ **Created:** [July 15, 2008, 10:45pm UTC](https://www.ruby-forum.com/t/code-review-unni1/143166 "2008-07-15T22:45:13Z")\ **Posts on this page:** 8\ **Page:** 1
**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\ **Post date:** [July 15, 2008, 10:45pm UTC](https://www.ruby-forum.com/t/code-review-unni1/143166/1 "2008-07-15T22:45:13Z")
tfpt review “/shelveset:unni1;REDMOND\jdeville” Comment : Patch from Unnikrishnan N. to properly handle File.zero? for ‘NUL’ ---
**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\ **Post date:** [July 15, 2008, 11:32pm UTC](https://www.ruby-forum.com/t/code-review-unni1/143166/2 "2008-07-15T23:32:02Z")
Reviewed F2F with John JD ---
**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\ **Post date:** [July 15, 2008, 11:51pm UTC](https://www.ruby-forum.com/t/code-review-unni1/143166/3 "2008-07-15T23:51:57Z")
While testing this manually I discovered that CRuby treats nul and NUL as zero length files, while this patch only works for NUL. Unni, can you fix that and resubmit? Thanks, JD ---
**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\ **Post date:** [July 16, 2008, 6:44pm UTC](https://www.ruby-forum.com/t/code-review-unni1/143166/4 "2008-07-16T18:44:14Z")
yes, I will do that. Thanks. Unni — On Tue, 7/15/08, Jim D. [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) wrote: From: Jim D. [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) Subject: Re: [Ironruby-core] Code Review: unni1 To: “removed\_email\_address@domain.invalid” [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid), “IronRuby External Code R.” [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) Date: Tuesday, July 15, 2008, 3:51 PM While testing this manually I discovered that CRuby treats nul and NUL as zero length files, while this patch only works for NUL. Unni, can you fix that and resubmit? Thanks, JD ---
**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\ **Post date:** [July 17, 2008, 5:03am UTC](https://www.ruby-forum.com/t/code-review-unni1/143166/5 "2008-07-17T05:03:29Z")
Jim, Â As per your comments, I have modified the code and ran against Matz Ruby and verified the results. Yes you are correct ‘nul’ is same as ‘NUL’ as well. I have updated the patch as well. Â Just curious, how come there is no representation of IronRuby in Lonestar Ruby conference? Â Thanks. Unni — On Wed, 7/16/08, Unnikrishnan N. [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) wrote: From: Unnikrishnan N. [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) Subject: Re: [Ironruby-core] Code Review: unni1 To: removed\_email\_address@domain.invalid Date: Wednesday, July 16, 2008, 10:34 AM yes, I will do that. Thanks. Unni — On Tue, 7/15/08, Jim D. [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) wrote: From: Jim D. [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) Subject: Re: [Ironruby-core] Code Review: unni1 To: “removed\_email\_address@domain.invalid” [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid), “IronRuby External Code R.” [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) Date: Tuesday, July 15, 2008, 3:51 PM While testing this manually I discovered that CRuby treats nul and NUL as zero length files, while this patch only works for NUL. Unni, can you fix that and resubmit? Thanks, JD ---
**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\ **Post date:** [July 17, 2008, 5:11am UTC](https://www.ruby-forum.com/t/code-review-unni1/143166/6 "2008-07-17T05:11:05Z")
Cool, I’ll get that integrated into the repo. I don’t know why we didn’t send someone to Lonestar. Probably just a case of limited resources. JD From: removed\_email\_address@domain.invalid [[mailto:removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid)] On Behalf Of Unnikrishnan Nair Sent: Wednesday, July 16, 2008 7:52 PM To: removed\_email\_address@domain.invalid Subject: Re: [Ironruby-core] Code Review: unni1 Jim, As per your comments, I have modified the code and ran against Matz Ruby and verified the results. Yes you are correct ‘nul’ is same as ‘NUL’ as well. I have updated the patch as well. Just curious, how come there is no representation of IronRuby in Lonestar Ruby conference? Thanks. Unni — On Wed, 7/16/08, Unnikrishnan N. [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) wrote: From: Unnikrishnan N. [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) Subject: Re: [Ironruby-core] Code Review: unni1 To: removed\_email\_address@domain.invalid Date: Wednesday, July 16, 2008, 10:34 AM yes, I will do that. Thanks. Unni — On Tue, 7/15/08, Jim D. [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) wrote: From: Jim D. [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) Subject: Re: [Ironruby-core] Code Review: unni1 To: “removed\_email\_address@domain.invalid” [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid), “IronRuby External Code R.” [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) Date: Tuesday, July 15, 2008, 3:51 PM While testing this manually I discovered that CRuby treats nul and NUL as zero length files, while this patch only works for NUL. Unni, can you fix that and resubmit? Thanks, JD > -----Original Message----- > From: removed\_email\_address@domain.invalid [mailto:ironruby-core- > removed\_email\_address@domain.invalid] On Behalf Of Jim D. > Sent: Tuesday, July 15, 2008 2:31 PM > To: removed\_email\_address@domain.invalid; IronRuby External Code R. > Subject: Re: [Ironruby-core] Code Review: unni1 > > Reviewed F2F with John > > > JD > > > -----Original Message----- > > From: removed\_email\_address@domain.invalid [mailto:ironruby-core- > > removed\_email\_address@domain.invalid] On Behalf Of Jim D. > > Sent: Tuesday, July 15, 2008 1:45 PM > > To: IronRuby External Code R. > > Cc: removed\_email\_address@domain.invalid > > Subject: [Ironruby-core] Code Review: unni1 > > > > tfpt review “/shelveset:unni1;REDMOND\jdeville” > > Comment : > > Patch from Unnikrishnan N. to properly handle File.zero? for > ‘NUL’ > > > > * * * > Ironruby-core mailing list > removed\_email\_address@domain.invalid > [http://rubyforge.org/mailman/listinfo/ironruby-core](http://rubyforge.org/mailman/listinfo/ironruby-core) * * * Ironruby-core mailing list removed\_email\_address@domain.invalid [http://rubyforge.org/mailman/listinfo/ironruby-core](http://rubyforge.org/mailman/listinfo/ironruby-core) * * * Ironruby-core mailing list removed\_email\_address@domain.invalid [http://rubyforge.org/mailman/listinfo/ironruby-core](http://rubyforge.org/mailman/listinfo/ironruby-core) ---
**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\ **Post date:** [July 17, 2008, 5:24pm UTC](https://www.ruby-forum.com/t/code-review-unni1/143166/7 "2008-07-17T17:24:16Z")
As much as we would love to attend more Ruby conferences (and there are a LOT of Ruby conferences!), we really don’t have the bandwidth. So we’re being very careful about where we go. We’ll be at RubyConf this year. Thanks, -John From: removed\_email\_address@domain.invalid [[mailto:removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid)] On Behalf Of Unnikrishnan Nair Sent: Wednesday, July 16, 2008 10:52 PM To: removed\_email\_address@domain.invalid Subject: Re: [Ironruby-core] Code Review: unni1 Jim, As per your comments, I have modified the code and ran against Matz Ruby and verified the results. Yes you are correct ‘nul’ is same as ‘NUL’ as well. I have updated the patch as well. Just curious, how come there is no representation of IronRuby in Lonestar Ruby conference? Thanks. Unni — On Wed, 7/16/08, Unnikrishnan N. [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) wrote: From: Unnikrishnan N. [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) Subject: Re: [Ironruby-core] Code Review: unni1 To: removed\_email\_address@domain.invalid Date: Wednesday, July 16, 2008, 10:34 AM yes, I will do that. Thanks. Unni — On Tue, 7/15/08, Jim D. [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) wrote: From: Jim D. [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) Subject: Re: [Ironruby-core] Code Review: unni1 To: “removed\_email\_address@domain.invalid” [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid), “IronRuby External Code R.” [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid) Date: Tuesday, July 15, 2008, 3:51 PM While testing this manually I discovered that CRuby treats nul and NUL as zero length files, while this patch only works for NUL. Unni, can you fix that and resubmit? Thanks, JD > -----Original Message----- > From: removed\_email\_address@domain.invalid [mailto:ironruby-core- > removed\_email\_address@domain.invalid] On Behalf Of Jim D. > Sent: Tuesday, July 15, 2008 2:31 PM > To: removed\_email\_address@domain.invalid; IronRuby External Code R. > Subject: Re: [Ironruby-core] Code Review: unni1 > > Reviewed F2F with John > > > JD > > > -----Original Message----- > > From: removed\_email\_address@domain.invalid [mailto:ironruby-core- > > removed\_email\_address@domain.invalid] On Behalf Of Jim D. > > Sent: Tuesday, July 15, 2008 1:45 PM > > To: IronRuby External Code R. > > Cc: removed\_email\_address@domain.invalid > > Subject: [Ironruby-core] Code Review: unni1 > > > > tfpt review “/shelveset:unni1;REDMOND\jdeville” > > Comment : > > Patch from Unnikrishnan N. to properly handle File.zero? for > ‘NUL’ > > > > * * * > Ironruby-core mailing list > removed\_email\_address@domain.invalid > [http://rubyforge.org/mailman/listinfo/ironruby-core](http://rubyforge.org/mailman/listinfo/ironruby-core) * * * Ironruby-core mailing list removed\_email\_address@domain.invalid [http://rubyforge.org/mailman/listinfo/ironruby-core](http://rubyforge.org/mailman/listinfo/ironruby-core) * * * Ironruby-core mailing list removed\_email\_address@domain.invalid [http://rubyforge.org/mailman/listinfo/ironruby-core](http://rubyforge.org/mailman/listinfo/ironruby-core) ---
**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\ **Post date:** [July 17, 2008, 5:29pm UTC](https://www.ruby-forum.com/t/code-review-unni1/143166/8 "2008-07-17T17:29:32Z")
I was really looking forward to meet you guys here at Texas, well next time. Matz is giving the key note. Thanks. Unni