# Code Review: testfixes-1

**URL:** <https://www.ruby-forum.com/t/code-review-testfixes-1/137712>\
**Category:** IronRuby\
**Created:** [May 15, 2008, 4:33pm UTC](https://www.ruby-forum.com/t/code-review-testfixes-1/137712 "2008-05-15T16:33:42Z")\
**Posts on this page:** 1\
**Page:** 1

<div class="post-metadata">

**Author:** ![John\_LSSIRONRUBY](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/j/4491bb/32.png) [@John\_LSSIRONRUBY](https://www.ruby-forum.com/u/John_LSSIRONRUBY)\
**Post date:** [May 15, 2008, 4:33pm UTC](https://www.ruby-forum.com/t/code-review-testfixes-1/137712/1 "2008-05-15T16:33:42Z")

</div>

tfpt review /shelveset:testfixes-1;REDMOND\jflam

This fixes a broken test in run0 (test\_dir.rb) which had a dependency on  
the existence of environment variables that may not exist on local  
developer machines.

It fixes the performance degredation in spec\_runner.rb

It also fixes a number of specs that broke when we changed how  
directories were traversed by spec\_runner.

Thanks,  
-John