# Code Review: systemstack

**URL:** <https://www.ruby-forum.com/t/code-review-systemstack/140719>\
**Category:** IronRuby\
**Created:** [June 17, 2008, 10:36pm UTC](https://www.ruby-forum.com/t/code-review-systemstack/140719 "2008-06-17T22:36:48Z")\
**Posts on this page:** 4\
**Page:** 1

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [June 17, 2008, 10:36pm UTC](https://www.ruby-forum.com/t/code-review-systemstack/140719/1 "2008-06-17T22:36:48Z")

</div>

Ruby Only

Changes the exception inheritance tree to put SystemStackError under  
StandardError to match CRuby

---

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [June 17, 2008, 10:38pm UTC](https://www.ruby-forum.com/t/code-review-systemstack/140719/2 "2008-06-17T22:38:34Z")

</div>

For those internal: tfpt review “/shelveset:systemstack;jdeville”

From: removed\_email\_address@domain.invalid  
[[mailto:removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid)] On Behalf Of Jim D.  
Sent: Tuesday, June 17, 2008 1:36 PM  
To: removed\_email\_address@domain.invalid; IronRuby External Code R.  
Subject: [Ironruby-core] Code Review: systemstack

Ruby Only

Changes the exception inheritance tree to put SystemStackError under  
StandardError to match CRuby

---

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [June 17, 2008, 10:42pm UTC](https://www.ruby-forum.com/t/code-review-systemstack/140719/3 "2008-06-17T22:42:07Z")

</div>

Looks good.

From: Jim D.  
Sent: Tuesday, June 17, 2008 1:38 PM  
To: removed\_email\_address@domain.invalid; IronRuby External Code R.  
Subject: RE: Code Review: systemstack

For those internal: tfpt review “/shelveset:systemstack;jdeville”

From: removed\_email\_address@domain.invalid  
[[mailto:removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid)] On Behalf Of Jim D.  
Sent: Tuesday, June 17, 2008 1:36 PM  
To: removed\_email\_address@domain.invalid; IronRuby External Code R.  
Subject: [Ironruby-core] Code Review: systemstack

Ruby Only

Changes the exception inheritance tree to put SystemStackError under  
StandardError to match CRuby

---

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [June 17, 2008, 10:43pm UTC](https://www.ruby-forum.com/t/code-review-systemstack/140719/4 "2008-06-17T22:43:52Z")

</div>

Also F2F with John.

From: Tomas M.  
Sent: Tuesday, June 17, 2008 1:41 PM  
To: Jim D.; removed\_email\_address@domain.invalid; IronRuby External Code  
Reviewers  
Subject: RE: Code Review: systemstack

Looks good.

From: Jim D.  
Sent: Tuesday, June 17, 2008 1:38 PM  
To: removed\_email\_address@domain.invalid; IronRuby External Code R.  
Subject: RE: Code Review: systemstack

For those internal: tfpt review “/shelveset:systemstack;jdeville”

From: removed\_email\_address@domain.invalid  
[[mailto:removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid)] On Behalf Of Jim D.  
Sent: Tuesday, June 17, 2008 1:36 PM  
To: removed\_email\_address@domain.invalid; IronRuby External Code R.  
Subject: [Ironruby-core] Code Review: systemstack

Ruby Only

Changes the exception inheritance tree to put SystemStackError under  
StandardError to match CRuby