# Code Review: Symbols and YAML

**URL:** <https://www.ruby-forum.com/t/code-review-symbols-and-yaml/182420>\
**Category:** IronRuby\
**Created:** [January 27, 2010, 7:30pm UTC](https://www.ruby-forum.com/t/code-review-symbols-and-yaml/182420 "2010-01-27T19:30:24Z")\
**Posts on this page:** 2\
**Page:** 1

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [January 27, 2010, 7:30pm UTC](https://www.ruby-forum.com/t/code-review-symbols-and-yaml/182420/1 "2010-01-27T19:30:24Z")

</div>

tfpt review /shelveset:RSym14;tomat

DLR:  
Adds ExpressionCollectionBuilder as a specialization of  
ExpressionCollectionBuilder.

Ruby:  
Replaces SymbolId usage by RubySymbol class. Ruby symbols are possibly  
encoded interned frozen strings.  
Enables KCODE on Silverlight.  
Allows class reopening in libraries (a class defined in Ruby can be  
reopened by a library class).  
Fixes bunch of bugs in YAML.

Fixes  
[http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=3466](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=3466)

Tomas

---

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [January 28, 2010, 12:42pm UTC](https://www.ruby-forum.com/t/code-review-symbols-and-yaml/182420/2 "2010-01-28T12:42:52Z")

</div>

It is more general. Any expression tree node that holds on a list of  
Expressions could (should ultimately) have its factory there, not just  
MethodCall.

Tomas

From: Dino Viehland  
Sent: Wednesday, January 27, 2010 10:36 AM  
To: Tomas M.; IronRuby External Code R.; Rowan Code  
Reviewers  
Cc: removed\_email\_address@domain.invalid  
Subject: RE: Code Review: Symbols and YAML

Shouldn’t ExpressionCollectionBuilder be more appropriately called  
CallExpressionBuilder? Other than that looks fine.

From: Tomas M.  
Sent: Wednesday, January 27, 2010 10:27 AM  
To: IronRuby External Code R.; Rowan Code R.  
Cc: removed\_email\_address@domain.invalid  
Subject: Code Review: Symbols and YAML

tfpt review /shelveset:RSym14;tomat

DLR:  
Adds ExpressionCollectionBuilder as a specialization of  
ExpressionCollectionBuilder.

Ruby:  
Replaces SymbolId usage by RubySymbol class. Ruby symbols are possibly  
encoded interned frozen strings.  
Enables KCODE on Silverlight.  
Allows class reopening in libraries (a class defined in Ruby can be  
reopened by a library class).  
Fixes bunch of bugs in YAML.

Fixes  
[http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=3466](http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=3466)

Tomas