# Code Review: Spec changes **URL:** \ **Category:** IronRuby\ **Created:** [July 15, 2008, 7:23am UTC](https://www.ruby-forum.com/t/code-review-spec-changes/143099 "2008-07-15T07:23:33Z")\ **Posts on this page:** 4\ **Page:** 1
**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\ **Post date:** [July 15, 2008, 7:23am UTC](https://www.ruby-forum.com/t/code-review-spec-changes/143099/1 "2008-07-15T07:23:33Z")
tfpt review “/shelveset:rubyspec2;jdeville” - ``` Changed all invocations of mspec to use the mspec command with ``` Ruby instead of the mspec-ci or mspec-run command with IronRuby. This will allow us to take advantage of future options added to the mspec runner, and possibly add parallel process support if it gets added to mspec. - ``` Changed the custom runners for baseline and tag to mspec ci ``` and mspec tag. No reason to invent the wheel, and this is how SNAP will be running. This has the side effect of changing the tags to fails from fail - ``` Added the -G critical option to all runners. Critical tags ``` will be used to mark IronRuby bugs that block the runner. This is based on a discussion on #rubyspec about how other implementations are tracking bugs. The tag file is how things should be excluded unless they are bugs with the reference implementation (CRuby). Thus instead of the ironruby\_bug guard, I have moved to a critical tag, which can be regenerated from this file. - ``` Added a method to generate the tags from an existing ``` critical\_tags.txt file. Currently this file is the output of Powershell’s Get-Child-Items -r -i \*.txt | select-string critical, with some modification to remove new lines. Suggestions for options for automatically generating this file are welcome. - ``` Added a rake task (regen_tags) to generate the critical tags. ``` Github commits: IronRuby-tags: 90e33e19 Added a critical tags file to regenerate tags from. c5f6359 Rebaselined the specs. Mspec: 18db1cf ``` Added critical tag to mspec ci Reordered tmp helper to respect ENV variables before ``` attempting to guess. Rubyspec: 1e57876 ``` Removed ironruby_bug guards due to the change to ``` critical tags. ---
**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\ **Post date:** [July 15, 2008, 11:32pm UTC](https://www.ruby-forum.com/t/code-review-spec-changes/143099/2 "2008-07-15T23:32:02Z")
Reviewed F2F with John. JD From: removed\_email\_address@domain.invalid [[mailto:removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid)] On Behalf Of Jim D. Sent: Monday, July 14, 2008 10:22 PM To: removed\_email\_address@domain.invalid; IronRuby External Code R.; Srivatsn Narayanan Subject: [Ironruby-core] Code Review: Spec changes tfpt review “/shelveset:rubyspec2;jdeville” - ``` Changed all invocations of mspec to use the mspec command with ``` Ruby instead of the mspec-ci or mspec-run command with IronRuby. This will allow us to take advantage of future options added to the mspec runner, and possibly add parallel process support if it gets added to mspec. - ``` Changed the custom runners for baseline and tag to mspec ci ``` and mspec tag. No reason to invent the wheel, and this is how SNAP will be running. This has the side effect of changing the tags to fails from fail - ``` Added the -G critical option to all runners. Critical tags ``` will be used to mark IronRuby bugs that block the runner. This is based on a discussion on #rubyspec about how other implementations are tracking bugs. The tag file is how things should be excluded unless they are bugs with the reference implementation (CRuby). Thus instead of the ironruby\_bug guard, I have moved to a critical tag, which can be regenerated from this file. - ``` Added a method to generate the tags from an existing ``` critical\_tags.txt file. Currently this file is the output of Powershell’s Get-Child-Items -r -i \*.txt | select-string critical, with some modification to remove new lines. Suggestions for options for automatically generating this file are welcome. - ``` Added a rake task (regen_tags) to generate the critical tags. ``` Github commits: IronRuby-tags: 90e33e19 Added a critical tags file to regenerate tags from. c5f6359 Rebaselined the specs. Mspec: 18db1cf ``` Added critical tag to mspec ci Reordered tmp helper to respect ENV variables before ``` attempting to guess. Rubyspec: 1e57876 ``` Removed ironruby_bug guards due to the change to ``` critical tags. ---
**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\ **Post date:** [July 15, 2008, 11:50pm UTC](https://www.ruby-forum.com/t/code-review-spec-changes/143099/3 "2008-07-15T23:50:47Z")
Can you send links to github instead of just the commit sha1? * * * From: removed\_email\_address@domain.invalid [removed\_email\_address@domain.invalid] On Behalf Of Jim D. [removed\_email\_address@domain.invalid] Sent: Tuesday, July 15, 2008 2:31 PM To: removed\_email\_address@domain.invalid; IronRuby External Code R.; Srivatsn Narayanan Subject: Re: [Ironruby-core] Code Review: Spec changes Reviewed F2F with John. JD From: removed\_email\_address@domain.invalid [[mailto:removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid)] On Behalf Of Jim D. Sent: Monday, July 14, 2008 10:22 PM To: removed\_email\_address@domain.invalid; IronRuby External Code R.; Srivatsn Narayanan Subject: [Ironruby-core] Code Review: Spec changes tfpt review “/shelveset:rubyspec2;jdeville” • Changed all invocations of mspec to use the mspec command with Ruby instead of the mspec-ci or mspec-run command with IronRuby. This will allow us to take advantage of future options added to the mspec runner, and possibly add parallel process support if it gets added to mspec. • Changed the custom runners for baseline and tag to mspec ci and mspec tag. No reason to invent the wheel, and this is how SNAP will be running. This has the side effect of changing the tags to fails from fail • Added the -G critical option to all runners. Critical tags will be used to mark IronRuby bugs that block the runner. This is based on a discussion on #rubyspec about how other implementations are tracking bugs. The tag file is how things should be excluded unless they are bugs with the reference implementation (CRuby). Thus instead of the ironruby\_bug guard, I have moved to a critical tag, which can be regenerated from this file. • Added a method to generate the tags from an existing critical\_tags.txt file. Currently this file is the output of Powershell’s Get-Child-Items -r -i \*.txt | select-string critical, with some modification to remove new lines. Suggestions for options for automatically generating this file are welcome. • Added a rake task (regen\_tags) to generate the critical tags. Github commits: IronRuby-tags: 90e33e19 Added a critical tags file to regenerate tags from. c5f6359 Rebaselined the specs. Mspec: 18db1cf ``` Added critical tag to mspec ci Reordered tmp helper to respect ENV variables before ``` attempting to guess. Rubyspec: 1e57876 ``` Removed ironruby_bug guards due to the change to ``` critical tags. ---
**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\ **Post date:** [July 16, 2008, 7:56am UTC](https://www.ruby-forum.com/t/code-review-spec-changes/143099/4 "2008-07-16T07:56:54Z")
I remembered that shortly after I sent this mail last night. One of these times I will get it. JD From: removed\_email\_address@domain.invalid [[mailto:removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid)] On Behalf Of Jimmy Schementi Sent: Tuesday, July 15, 2008 2:49 PM To: removed\_email\_address@domain.invalid; IronRuby External Code R.; Srivatsn Narayanan Subject: Re: [Ironruby-core] Code Review: Spec changes Can you send links to github instead of just the commit sha1? * * * From: removed\_email\_address@domain.invalid [removed\_email\_address@domain.invalid] On Behalf Of Jim D. [removed\_email\_address@domain.invalid] Sent: Tuesday, July 15, 2008 2:31 PM To: removed\_email\_address@domain.invalid; IronRuby External Code R.; Srivatsn Narayanan Subject: Re: [Ironruby-core] Code Review: Spec changes Reviewed F2F with John. JD From: removed\_email\_address@domain.invalid [[mailto:removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid)] On Behalf Of Jim D. Sent: Monday, July 14, 2008 10:22 PM To: removed\_email\_address@domain.invalid; IronRuby External Code R.; Srivatsn Narayanan Subject: [Ironruby-core] Code Review: Spec changes tfpt review “/shelveset:rubyspec2;jdeville” - ``` Changed all invocations of mspec to use the mspec command with ``` Ruby instead of the mspec-ci or mspec-run command with IronRuby. This will allow us to take advantage of future options added to the mspec runner, and possibly add parallel process support if it gets added to mspec. - ``` Changed the custom runners for baseline and tag to mspec ci ``` and mspec tag. No reason to invent the wheel, and this is how SNAP will be running. This has the side effect of changing the tags to fails from fail - ``` Added the -G critical option to all runners. Critical tags ``` will be used to mark IronRuby bugs that block the runner. This is based on a discussion on #rubyspec about how other implementations are tracking bugs. The tag file is how things should be excluded unless they are bugs with the reference implementation (CRuby). Thus instead of the ironruby\_bug guard, I have moved to a critical tag, which can be regenerated from this file. - ``` Added a method to generate the tags from an existing ``` critical\_tags.txt file. Currently this file is the output of Powershell’s Get-Child-Items -r -i \*.txt | select-string critical, with some modification to remove new lines. Suggestions for options for automatically generating this file are welcome. - ``` Added a rake task (regen_tags) to generate the critical tags. ``` Github commits: IronRuby-tags: 90e33e19 Added a critical tags file to regenerate tags from. c5f6359 Rebaselined the specs. Mspec: 18db1cf ``` Added critical tag to mspec ci Reordered tmp helper to respect ENV variables before ``` attempting to guess. Rubyspec: 1e57876 ``` Removed ironruby_bug guards due to the change to ``` critical tags.