# Code review: socketpatch

**URL:** <https://www.ruby-forum.com/t/code-review-socketpatch/140113>\
**Category:** IronRuby\
**Created:** [June 11, 2008, 12:39am UTC](https://www.ruby-forum.com/t/code-review-socketpatch/140113 "2008-06-11T00:39:34Z")\
**Posts on this page:** 2\
**Page:** 1

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [June 11, 2008, 12:39am UTC](https://www.ruby-forum.com/t/code-review-socketpatch/140113/1 "2008-06-11T00:39:34Z")

</div>

Ruby only

Tfpt review /shelveset:socketpatch;jdeville

External patch from Peter Bacon D. resolving Rubyforge bug [#20517]  
Socket::Constants not defined

JD

---

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [June 11, 2008, 1:32am UTC](https://www.ruby-forum.com/t/code-review-socketpatch/140113/2 "2008-06-11T01:32:53Z")

</div>

Looks good as well.

From: Jim D.  
Sent: Tuesday, June 10, 2008 3:39 PM  
To: John L. (IRONRUBY); Oleg T.; Tomas M.; Rowan Code  
Reviewers  
Cc: removed\_email\_address@domain.invalid  
Subject: Code review: socketpatch

Ruby only

Tfpt review /shelveset:socketpatch;jdeville

External patch from Peter Bacon D. resolving Rubyforge bug [#20517]  
Socket::Constants not defined

JD