# Code Review: Simple ruby fixes

**URL:** <https://www.ruby-forum.com/t/code-review-simple-ruby-fixes/155177>\
**Category:** IronRuby\
**Created:** [December 9, 2008, 1:47am UTC](https://www.ruby-forum.com/t/code-review-simple-ruby-fixes/155177 "2008-12-09T01:47:58Z")\
**Posts on this page:** 3\
**Page:** 1

<div class="post-metadata">

**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\
**Post date:** [December 9, 2008, 1:47am UTC](https://www.ruby-forum.com/t/code-review-simple-ruby-fixes/155177/1 "2008-12-09T01:47:58Z")

</div>

tfpt review “/shelveset:rt;REDMOND\sborde”

Comment :  
Simple fixes to the simple\_test.rb runner as I was trying to get a  
feel for all the moving parts in Ruby testing. “finished” was not  
setting the exitcode, and so we were ignoring some failures, I disabled  
some of the tests, and fixed the trivial ones.  
Changed the Ruby method binder to throw AmbiguousMatchException for  
ambiguous method overloads, as throwing the ArgumentException was  
misleading.  
Added an alias for building just Microsoft.Scripting.dll

---

<div class="post-metadata">

**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\
**Post date:** [December 9, 2008, 1:59am UTC](https://www.ruby-forum.com/t/code-review-simple-ruby-fixes/155177/2 "2008-12-09T01:59:39Z")

</div>

Can you update Alias.ps1 as well? Otherwise looks good.

JD

---

<div class="post-metadata">

**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\
**Post date:** [December 9, 2008, 5:43am UTC](https://www.ruby-forum.com/t/code-review-simple-ruby-fixes/155177/3 "2008-12-09T05:43:35Z")

</div>

Looks good.

Tomas