# Code Review: ShellExec7

**URL:** <https://www.ruby-forum.com/t/code-review-shellexec7/176455>\
**Category:** IronRuby\
**Created:** [September 30, 2009, 8:00pm UTC](https://www.ruby-forum.com/t/code-review-shellexec7/176455 "2009-09-30T20:00:02Z")\
**Posts on this page:** 1\
**Page:** 1

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [September 30, 2009, 8:00pm UTC](https://www.ruby-forum.com/t/code-review-shellexec7/176455/1 "2009-09-30T20:00:02Z")

</div>

tfpt review “/shelveset:ShellExec7;REDMOND\tomat”  
Comment :  
Fixes issues with Kernel#`, system and exec. Paths with spaces and shell commands were not handled correctly. Also fixes a bug in mspec/lib/mspec/helpers/ruby_exe.rb - it didn't handle spaces in RUBY_EXE path correctly. Implements Win32API library - irb depends on it if run on Windows and it "worked" only due to a bug in Kernel#`.  
Fixes IO#tty? - it only returns true if the console stream is not  
redirected to a file or a pipe. Adds some specs to test this.  
Disables Process::UID and Process::Sys specs on Windows.

Tomas