# Code Review: scripts

**URL:** <https://www.ruby-forum.com/t/code-review-scripts/162510>\
**Category:** IronRuby\
**Created:** [March 10, 2009, 6:19pm UTC](https://www.ruby-forum.com/t/code-review-scripts/162510 "2009-03-10T18:19:04Z")\
**Posts on this page:** 2\
**Page:** 1

<div class="post-metadata">

**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\
**Post date:** [March 10, 2009, 6:19pm UTC](https://www.ruby-forum.com/t/code-review-scripts/162510/1 "2009-03-10T18:19:04Z")

</div>

tfpt review “/shelveset:scripts;REDMOND\sborde”

Comment :  
Code change:  
Small fix in Shell\CommandLine.cs to deal with newlines consistently  
(user-reported issue).

Scripts:  
Moves RunRSpec.cmd and irtests.bat from Merlin\Main\Scripts to  
Merlin\Languages\Ruby\Scripts so that they are available in GIT.  
Also changed them so that they do not rely on  
Merlin\Main\test\scripts\ir.cmd which does not exist in GIT and is  
needed only when Snap runs various modes like with/without  
interpretation, etc.

---

<div class="post-metadata">

**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\
**Post date:** [March 11, 2009, 12:33am UTC](https://www.ruby-forum.com/t/code-review-scripts/162510/2 "2009-03-11T00:33:32Z")

</div>

Ruby Dev.bat:  
Can the RUBY19\_EXE check for its existence first (so I can override it,  
for example). I’d also like to not differentiate between GIT and  
non-GIT, with my comment below, we don’t need the GIT env. Variable.

Common.rb:  
I would say get rid of the nested if on line 42. If ROWAN\_BIN, use .cmd,  
otherwise, use.exe.

Otherwise looks good.

JD