# Code Review: ScopesAndCrossRuntime

**URL:** <https://www.ruby-forum.com/t/code-review-scopesandcrossruntime/155047>\
**Category:** IronRuby\
**Created:** [December 6, 2008, 11:00pm UTC](https://www.ruby-forum.com/t/code-review-scopesandcrossruntime/155047 "2008-12-06T23:00:03Z")\
**Posts on this page:** 3\
**Page:** 1

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [December 6, 2008, 11:00pm UTC](https://www.ruby-forum.com/t/code-review-scopesandcrossruntime/155047/1 "2008-12-06T23:00:03Z")

</div>

tfpt review “/shelveset:ScopesAndCrossRuntime;REDMOND\tomat”

DLR, Python, JS:  
A little bit of code context cleanup and dead code removal.

Ruby:

- 

```
Removes RubyScope <: CodeContext inheritance relationship.

```

- 

```
Implements isSelfContained flags for modules as it works for 

```

classes.

- 

```
Nests Clr module into a new IronRuby module that maps to 

```

IronRuby.Ruby hosting class. The hierarchy is as follows:  
module IronRuby  
module Clr  
def self.profile  
end  
end  
module ParseTree  
…  
end

#hosting methods:  
def self.create\_runtime  
def self.create\_engine  
…  
end

- 

```
Fixes bugs in cross-runtime object access, adds some tests. 

```

Prohibits adding methods and mixins to a class defined in a foreign  
runtime.

Tomas

---

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [December 7, 2008, 6:51am UTC](https://www.ruby-forum.com/t/code-review-scopesandcrossruntime/155047/2 "2008-12-07T06:51:26Z")

</div>

Mmm… I love the smell of dead CodeContext in the morning. It smells  
like victory!

Language changes look good.

---

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [December 7, 2008, 5:15pm UTC](https://www.ruby-forum.com/t/code-review-scopesandcrossruntime/155047/3 "2008-12-07T17:15:09Z")

</div>

Outer ring changes look beautiful too. This sure is a victory! Thank  
you, Tomas!

Martin