# Code Review: RubyInitializers8

**URL:** <https://www.ruby-forum.com/t/code-review-rubyinitializers8/153746>\
**Category:** IronRuby\
**Created:** [November 20, 2008, 7:00pm UTC](https://www.ruby-forum.com/t/code-review-rubyinitializers8/153746 "2008-11-20T19:00:09Z")\
**Posts on this page:** 2\
**Page:** 1

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [November 20, 2008, 7:00pm UTC](https://www.ruby-forum.com/t/code-review-rubyinitializers8/153746/1 "2008-11-20T19:00:09Z")

</div>

tfpt review “/shelveset:RubyInitializers8;REDMOND\tomat”  
Comment :  
Refactors call actions, reimplements calls to constructors, allocators  
and initializers.  
Implements allocate operation for built-in classes (where available in  
MRI).  
Fixes initialization of exceptions, Kernel#raise, and enables an  
arbitrary object to be an exception message.  
Simplifies C# definition of Ruby exceptions with a default factory:

- 

```
If RubyExceptionAttribute is used instead of RubyClassAttribute 

```

and no RubyConstructor is defined the default factory is generated and  
set up by init-generator.

Fixes CallArguments and MetaObjectBuilder: meta-arguments passed to  
Defer should not be modified.  
Refactors ArgsBuilder.

Tomas

---

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [November 20, 2008, 8:02pm UTC](https://www.ruby-forum.com/t/code-review-rubyinitializers8/153746/2 "2008-11-20T20:02:04Z")

</div>

The definition of OptionalParamCount in ArgsBuilder.cs looks wrong.

A gratuitous tab character snuck into IoOps.cs.

Not specific to this set of changes, it would be nice if the generation  
program for ReflectionCache.Generated were to apply some kind of  
deterministic sort to the methods being generated.