# Code Review: remove\_old\_spec

**URL:** <https://www.ruby-forum.com/t/code-review-remove-old-spec/148639>\
**Category:** IronRuby\
**Created:** [September 15, 2008, 8:30pm UTC](https://www.ruby-forum.com/t/code-review-remove-old-spec/148639 "2008-09-15T20:30:17Z")\
**Posts on this page:** 6\
**Page:** 1

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [September 15, 2008, 8:30pm UTC](https://www.ruby-forum.com/t/code-review-remove-old-spec/148639/1 "2008-09-15T20:30:17Z")

</div>

tfpt review “/shelveset:remove\_old\_spec;REDMOND\jdeville”  
Comment :  
This change removes the old specs from the test directory. It also  
removes the Rake tasks for those tests, and gets them out of SNAP.

---

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [September 15, 2008, 8:39pm UTC](https://www.ruby-forum.com/t/code-review-remove-old-spec/148639/2 "2008-09-15T20:39:10Z")

</div>

Rowantest.vbproj doesn’t have any changes. Could you sort the vsmdi  
(using sortvsmdi.py in test\scripts)? There are too many changes  
otherwise.

---

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [September 15, 2008, 8:55pm UTC](https://www.ruby-forum.com/t/code-review-remove-old-spec/148639/3 "2008-09-15T20:55:34Z")

</div>

Any idea why VS decided to check that file out?

I’m trying to get into the habit of running tfpt uu before shelving, but  
I missed it this time. I’ll run that and the sortvsmdi script and  
resubmit.

JD

---

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [September 15, 2008, 8:56pm UTC](https://www.ruby-forum.com/t/code-review-remove-old-spec/148639/4 "2008-09-15T20:56:09Z")

</div>

Actually it should have a change - the entry for rubyspec.generictest  
should get deleted from the vbproj file. I don’t know why its not there

- did you perhaps not save the vbproj when you closed vs?

---

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [September 15, 2008, 10:09pm UTC](https://www.ruby-forum.com/t/code-review-remove-old-spec/148639/5 "2008-09-15T22:09:00Z")

</div>

Fixed, can you recheck for me? Same shelveset

JD

---

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [September 15, 2008, 11:17pm UTC](https://www.ruby-forum.com/t/code-review-remove-old-spec/148639/6 "2008-09-15T23:17:07Z")

</div>

There is a “Tests Not in a list” testlist in the vsmdi. Its there  
because some hosting tests don’t belong to any testlist. I’ll talk to  
sesh about cleaning it up but can you remove this manually in the  
meanwhile (as in using notepad). This screws up SNAP otherwise.

Otherwise it looks good. Go ahead with it after fixing the vsmdi.