# Code Review: Regex6

**URL:** <https://www.ruby-forum.com/t/code-review-regex6/138823>\
**Category:** IronRuby\
**Created:** [May 28, 2008, 3:38am UTC](https://www.ruby-forum.com/t/code-review-regex6/138823 "2008-05-28T03:38:45Z")\
**Posts on this page:** 1\
**Page:** 1

<div class="post-metadata">

**Author:** ![grujildo](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/g/94ad74/32.png) [@grujildo](https://www.ruby-forum.com/u/grujildo)\
**Post date:** [May 28, 2008, 3:38am UTC](https://www.ruby-forum.com/t/code-review-regex6/138823/1 "2008-05-28T03:38:45Z")

</div>

tfpt review “/shelveset:Regex6;REDMOND\tomat”

Regexp fixes:

- 

```
  Implements Regexp.initialize

```

- 

```
  Fixes Regexp.new and compile signatures.

```

- 

```
  Regexp.new does no escaping, it just takes whatever string is 

```

given and makes up Regexp

- 

```
  Regexp.to_s returns 

```

“(?{enabled-options}-{disabled-options}:{pattern-with-forward-slash-escaped})”

- 

```
  Regexp.inspect returs "/{pattern-with-forward-slash-escaped}/"

```

- 

```
  Regexp.union does Regexp.escape (w/o calling it) on given 

```

strings (and objects converted using to\_str ) and does Regexp.to\_s  
(w/o calling it) on given regexes, concatenates all results using | as  
separator and calls Regexp.new(, nil, nil) on the result.

Fixes escaping of strings (String#inspect).  
Fixes chr, IO.write to honor current encoding.  
Makes ConsoleStreams host-redirectable.

Tomas