# Code Review: re

**URL:** <https://www.ruby-forum.com/t/code-review-re/160100>\
**Category:** IronRuby\
**Created:** [February 11, 2009, 8:25pm UTC](https://www.ruby-forum.com/t/code-review-re/160100 "2009-02-11T20:25:02Z")\
**Posts on this page:** 3\
**Page:** 1

<div class="post-metadata">

**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\
**Post date:** [February 11, 2009, 8:25pm UTC](https://www.ruby-forum.com/t/code-review-re/160100/1 "2009-02-11T20:25:02Z")

</div>

tfpt review “/shelveset:re;REDMOND\sborde”  
Comment :  
Fixes couple of remaining blocking bugs in re:  
Ruby’s /(?:m)/m should map to CLR’s “(?:s)”  
Hacky fix for /(expr){N}+/ should be treated like /(?:expr{N})+/

---

<div class="post-metadata">

**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\
**Post date:** [February 11, 2009, 8:56pm UTC](https://www.ruby-forum.com/t/code-review-re/160100/2 "2009-02-11T20:56:56Z")

</div>

Test looks good. I’ll also work on making the diff script include our  
tests in diff’s so the list can see them.

JD

---

<div class="post-metadata">

**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\
**Post date:** [February 16, 2009, 10:21pm UTC](https://www.ruby-forum.com/t/code-review-re/160100/3 "2009-02-16T22:21:07Z")

</div>

Looks good.

Tomas