# Code Review: RandomRubyFixes05

**URL:** <https://www.ruby-forum.com/t/code-review-randomrubyfixes05/151704>\
**Category:** IronRuby\
**Created:** [October 24, 2008, 5:32pm UTC](https://www.ruby-forum.com/t/code-review-randomrubyfixes05/151704 "2008-10-24T17:32:39Z")\
**Posts on this page:** 3\
**Page:** 1

<div class="post-metadata">

**Author:** ![curthibbs](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/c/ac91a4/32.png) [@curthibbs](https://www.ruby-forum.com/u/curthibbs)\
**Post date:** [October 24, 2008, 5:32pm UTC](https://www.ruby-forum.com/t/code-review-randomrubyfixes05/151704/1 "2008-10-24T17:32:39Z")

</div>

tfpt review “/shelveset:RandomRubyFixes05;REDMOND\curth”

Comment :  
Factored class IOWrapper.cs out of Marshal and into the Ruby core so  
it can be accessed from multiple places  
Factored object creation out of Marshal and into RubyUtils so it can  
share code with Yaml  
Disabled name-mangling for symbol “initialize” so that CLR methods  
with the name Initialize don’t cause trouble  
Implemented String.hex and String.oct  
Modified Socket and StringIO classes so they open in binary mode by  
default  
Extensive modifications to zlib:  
Fixed uncompressed blocks to inflate properly  
Reformatted to match standard  
Many small changes to cleanup code and improve performance  
Added support for reading from any object implementing “read” – not  
just IO objects – by using IOWrapper  
Added an overload to IO.seek that accepts BigInteger. (This turned  
out not to be needed, but the code works.)  
Modified Yaml construction to call yaml\_initialize if it exists

---

<div class="post-metadata">

**Author:** ![curthibbs](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/c/ac91a4/32.png) [@curthibbs](https://www.ruby-forum.com/u/curthibbs)\
**Post date:** [October 24, 2008, 8:24pm UTC](https://www.ruby-forum.com/t/code-review-randomrubyfixes05/151704/2 "2008-10-24T20:24:49Z")

</div>

YAML changes look good too.

–  
Oleg

---

<div class="post-metadata">

**Author:** ![curthibbs](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/c/ac91a4/32.png) [@curthibbs](https://www.ruby-forum.com/u/curthibbs)\
**Post date:** [October 24, 2008, 7:26pm UTC](https://www.ruby-forum.com/t/code-review-randomrubyfixes05/151704/3 "2008-10-24T19:26:45Z")

</div>

Looks good.

There is a minor formatting glitch in RubyUtils:

```
        return new 

```

RubyCompilerOptions(targetScope.ExecutionContext.Context.RubyOptions)  
{  
}

(the opening brace on a new line). I guess you need to set this in VS  
formatting options.

Tomas