# Code Review: RandomRubyFixes03

**URL:** <https://www.ruby-forum.com/t/code-review-randomrubyfixes03/150060>\
**Category:** IronRuby\
**Created:** [October 3, 2008, 12:26am UTC](https://www.ruby-forum.com/t/code-review-randomrubyfixes03/150060 "2008-10-03T00:26:49Z")\
**Posts on this page:** 2\
**Page:** 1

<div class="post-metadata">

**Author:** ![curthibbs](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/c/ac91a4/32.png) [@curthibbs](https://www.ruby-forum.com/u/curthibbs)\
**Post date:** [October 3, 2008, 12:26am UTC](https://www.ruby-forum.com/t/code-review-randomrubyfixes03/150060/1 "2008-10-03T00:26:49Z")

</div>

tfpt review “/shelveset:RandomRubyFixes03;REDMOND\curth”

Comment :  
Implement unpack directive L as equivalent to I on this platform  
Fix stack overflow resulting from inspecting recursive objects  
Fix instance variable operations to use consistent context/scope  
variable type  
Implement Proc.binding  
Implement Thread.abort\_on\_exception, Thread.value. Flow exceptions  
across Thread.join. (ThreadOps is now in need of some refactoring…)  
Supply stack trace when there’s no handler

---

<div class="post-metadata">

**Author:** ![curthibbs](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/c/ac91a4/32.png) [@curthibbs](https://www.ruby-forum.com/u/curthibbs)\
**Post date:** [October 3, 2008, 12:32am UTC](https://www.ruby-forum.com/t/code-review-randomrubyfixes03/150060/2 "2008-10-03T00:32:06Z")

</div>

Missing overflow check in ThreadOps.cs:259

if (!self.Join((int)(timeout \* 1000))) {

Other than that looks good.

Tomas