# Code Review: rakefix1

**URL:** <https://www.ruby-forum.com/t/code-review-rakefix1/152763>\
**Category:** IronRuby\
**Created:** [November 7, 2008, 8:57am UTC](https://www.ruby-forum.com/t/code-review-rakefix1/152763 "2008-11-07T08:57:59Z")\
**Posts on this page:** 2\
**Page:** 1

<div class="post-metadata">

**Author:** ![Seo\_S](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/439d5e/32.png) [@Seo\_S](https://www.ruby-forum.com/u/Seo_S)\
**Post date:** [November 7, 2008, 8:57am UTC](https://www.ruby-forum.com/t/code-review-rakefix1/152763/1 "2008-11-07T08:57:59Z")

</div>

Attached patch fixes (well, at least a bit of) Rake build. In  
particular, this patch fixes get\_case\_sensitive\_path to actually work.  
Current code does p.downcase.to\_s == filename, which assumes filename  
is already downcased, but filename is from \*.csproj and it actually is  
not, so at least it should be p.downcase == filename.downcase. Current  
code also does not deal with directory names differing in case.

---

<div class="post-metadata">

**Author:** ![Seo\_S](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/439d5e/32.png) [@Seo\_S](https://www.ruby-forum.com/u/Seo_S)\
**Post date:** [November 7, 2008, 9:17pm UTC](https://www.ruby-forum.com/t/code-review-rakefix1/152763/2 "2008-11-07T21:17:33Z")

</div>

Looks good!

JD