# Code Review: rakecrossplatform

**URL:** <https://www.ruby-forum.com/t/code-review-rakecrossplatform/156678>\
**Category:** IronRuby\
**Created:** [December 31, 2008, 9:22pm UTC](https://www.ruby-forum.com/t/code-review-rakecrossplatform/156678 "2008-12-31T21:22:10Z")\
**Posts on this page:** 5\
**Page:** 1

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [December 31, 2008, 9:22pm UTC](https://www.ruby-forum.com/t/code-review-rakecrossplatform/156678/1 "2008-12-31T21:22:10Z")

</div>

tfpt review “/shelveset:rakecrossplatform;REDMOND\jdeville”  
Comment :  
Fixes the imports to reference the files in a platform agnostic way.

---

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [December 31, 2008, 10:17pm UTC](https://www.ruby-forum.com/t/code-review-rakecrossplatform/156678/2 "2008-12-31T22:17:43Z")

</div>

Looks good!

---

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [December 31, 2008, 10:30pm UTC](https://www.ruby-forum.com/t/code-review-rakecrossplatform/156678/3 "2008-12-31T22:30:01Z")

</div>

I’m going to directly commit this since it doesn’t affect tests.

JD

---

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [January 1, 2009, 5:27am UTC](https://www.ruby-forum.com/t/code-review-rakecrossplatform/156678/4 "2009-01-01T05:27:26Z")

</div>

By the by, forward slashes are acceptable as path separators in windows  
as  
well as under unix. This /may/ be more acceptable as it’s clearer,  
IMHO.

---

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [January 2, 2009, 9:10pm UTC](https://www.ruby-forum.com/t/code-review-rakecrossplatform/156678/5 "2009-01-02T21:10:24Z")

</div>

Committing with Michael’s suggestion.

JD

From: removed\_email\_address@domain.invalid  
[[mailto:removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid)] On Behalf Of Michael  
Letterle  
Sent: Wednesday, December 31, 2008 8:23 PM  
To: removed\_email\_address@domain.invalid  
Subject: Re: [Ironruby-core] Code Review: rakecrossplatform

By the by, forward slashes are acceptable as path separators in windows  
as well as under unix. This /may/ be more acceptable as it’s clearer,  
IMHO.  
On Wed, Dec 31, 2008 at 4:29 PM, Jim D.  
\<removed\_email\_address@domain.invalid[mailto:removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid)\> wrote:  
I’m going to directly commit this since it doesn’t affect tests.

JD