# Code Review: rake\_compile

**URL:** <https://www.ruby-forum.com/t/code-review-rake-compile/153163>\
**Category:** IronRuby\
**Created:** [November 12, 2008, 8:46pm UTC](https://www.ruby-forum.com/t/code-review-rake-compile/153163 "2008-11-12T20:46:51Z")\
**Posts on this page:** 4\
**Page:** 1

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [November 12, 2008, 8:46pm UTC](https://www.ruby-forum.com/t/code-review-rake-compile/153163/1 "2008-11-12T20:46:51Z")

</div>

tfpt review “/shelveset:rake\_compile;REDMOND\jdeville”  
Comment :  
Fixes rake compile by adding a response file. This has been tested on  
both internal and external layouts.

```auto
JD
http://blog.jredville.com
```

---

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [November 12, 2008, 9:12pm UTC](https://www.ruby-forum.com/t/code-review-rake-compile/153163/2 "2008-11-12T21:12:13Z")

</div>

Looks good to me.

From: removed\_email\_address@domain.invalid  
[[mailto:removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid)] On Behalf Of Jim D.  
Sent: Wednesday, November 12, 2008 11:46 AM  
To: IronRuby External Code R.  
Cc: removed\_email\_address@domain.invalid  
Subject: [Ironruby-core] Code Review: rake\_compile

tfpt review “/shelveset:rake\_compile;REDMOND\jdeville”  
Comment :  
Fixes rake compile by adding a response file. This has been tested on  
both internal and external layouts.

```auto
JD
http://blog.jredville.com
```

---

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [November 13, 2008, 5:20am UTC](https://www.ruby-forum.com/t/code-review-rake-compile/153163/3 "2008-11-13T05:20:34Z")

</div>

2008/11/13 Jim D. [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid):

> Fixes rake compile by adding a response file. This has been tested on both  
> internal and external layouts.

Works fine on Linux system too. Thanks.

---

<div class="post-metadata">

**Author:** ![raker\_t](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/r/ecae2f/32.png) [@raker\_t](https://www.ruby-forum.com/u/raker_t)\
**Post date:** [November 13, 2008, 6:37am UTC](https://www.ruby-forum.com/t/code-review-rake-compile/153163/4 "2008-11-13T06:37:11Z")

</div>

Sure thing. I’m going to try to commit it and push a new SVN revision  
out tomorrow morning.

JD

* * *

From: removed\_email\_address@domain.invalid  
[removed\_email\_address@domain.invalid] On Behalf Of Seo S.  
[removed\_email\_address@domain.invalid]  
Sent: Wednesday, November 12, 2008 8:19 PM  
To: removed\_email\_address@domain.invalid  
Subject: Re: [Ironruby-core] Code Review: rake\_compile

2008/11/13 Jim D. [removed\_email\_address@domain.invalid](mailto:removed_email_address@domain.invalid):

> Fixes rake compile by adding a response file. This has been tested on both  
> internal and external layouts.

Works fine on Linux system too. Thanks.

–  
Seo S.

* * *

Ironruby-core mailing list  
removed\_email\_address@domain.invalid  
[http://rubyforge.org/mailman/listinfo/ironruby-core](http://rubyforge.org/mailman/listinfo/ironruby-core)