# Code Review: rails

**URL:** <https://www.ruby-forum.com/t/code-review-rails/182126>\
**Category:** IronRuby\
**Created:** [January 22, 2010, 11:27pm UTC](https://www.ruby-forum.com/t/code-review-rails/182126 "2010-01-22T23:27:28Z")\
**Posts on this page:** 4\
**Page:** 1

<div class="post-metadata">

**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\
**Post date:** [January 22, 2010, 11:27pm UTC](https://www.ruby-forum.com/t/code-review-rails/182126/1 "2010-01-22T23:27:28Z")

</div>

tfpt review “/shelveset:rails;REDMOND\sborde”  
Comment :  
Flushes out iconv implementation. Added more specs  
Made String#encoding visible only in 1.9 mode  
Adds optional paramter to StringScanner.new  
The above fixes enable many more Rails tests

---

<div class="post-metadata">

**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\
**Post date:** [January 22, 2010, 11:54pm UTC](https://www.ruby-forum.com/t/code-review-rails/182126/2 "2010-01-22T23:54:58Z")

</div>

Looks good, are the rails tests ready to go into SNAP?

JD

---

<div class="post-metadata">

**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\
**Post date:** [January 23, 2010, 1:04am UTC](https://www.ruby-forum.com/t/code-review-rails/182126/3 "2010-01-23T01:04:01Z")

</div>

Looks good.

Tomas

---

<div class="post-metadata">

**Author:** ![Shri\_B](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/s/898d66/32.png) [@Shri\_B](https://www.ruby-forum.com/u/Shri_B)\
**Post date:** [January 23, 2010, 1:38am UTC](https://www.ruby-forum.com/t/code-review-rails/182126/4 "2010-01-23T01:38:33Z")

</div>

Let me run them overnight to catch non-determinstic failures, but they  
have been reasonably stable so far.