# Code Review: rails-2

**URL:** <https://www.ruby-forum.com/t/code-review-rails-2/138317>\
**Category:** IronRuby\
**Created:** [May 22, 2008, 12:07am UTC](https://www.ruby-forum.com/t/code-review-rails-2/138317 "2008-05-22T00:07:30Z")\
**Posts on this page:** 3\
**Page:** 1

<div class="post-metadata">

**Author:** ![John\_LSSIRONRUBY](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/j/4491bb/32.png) [@John\_LSSIRONRUBY](https://www.ruby-forum.com/u/John_LSSIRONRUBY)\
**Post date:** [May 22, 2008, 12:07am UTC](https://www.ruby-forum.com/t/code-review-rails-2/138317/1 "2008-05-22T00:07:30Z")

</div>

tfpt review /shelveset:rails-2;REDMOND\jflam

This shelveset introduces fixes that are blocking us from

- Added missing define\_method overload for Proc
- Adding missing default constructors to StringIO and StringScanner
- We canonicalize paths returned from a few key File methods (\ -\> /)
- Introducing new Ruby\Libs directory to hold our redirect .rb files and  
hacks
- Modifying aliases and checking in ir.cmd
- Removing .EXE directory from $: search path

Thanks,  
-John

---

<div class="post-metadata">

**Author:** ![John\_LSSIRONRUBY](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/j/4491bb/32.png) [@John\_LSSIRONRUBY](https://www.ruby-forum.com/u/John_LSSIRONRUBY)\
**Post date:** [May 22, 2008, 3:11am UTC](https://www.ruby-forum.com/t/code-review-rails-2/138317/2 "2008-05-22T03:11:21Z")

</div>

In rbconfig.rb:

TOPDIR = File.dirname( **FILE** ).chomp!("/lib/ruby/1.8/i386-mswin32")

the path “/lib/ruby/1.8/i386-mswin32” needs to be replaced by the tail  
of the directory path where rbconfig.rb resides.

(otherwise chomp! will return nil)

Cheers, Wayne.

---

<div class="post-metadata">

**Author:** ![John\_LSSIRONRUBY](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/j/4491bb/32.png) [@John\_LSSIRONRUBY](https://www.ruby-forum.com/u/John_LSSIRONRUBY)\
**Post date:** [May 22, 2008, 3:59am UTC](https://www.ruby-forum.com/t/code-review-rails-2/138317/3 "2008-05-22T03:59:53Z")

</div>

Nice catch! Thanks!

Thanks,  
-John