# Code Review: rails-12

**URL:** <https://www.ruby-forum.com/t/code-review-rails-12/138708>\
**Category:** IronRuby\
**Created:** [May 27, 2008, 2:13am UTC](https://www.ruby-forum.com/t/code-review-rails-12/138708 "2008-05-27T02:13:54Z")\
**Posts on this page:** 2\
**Page:** 1

<div class="post-metadata">

**Author:** ![John\_LSSIRONRUBY](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/j/4491bb/32.png) [@John\_LSSIRONRUBY](https://www.ruby-forum.com/u/John_LSSIRONRUBY)\
**Post date:** [May 27, 2008, 2:13am UTC](https://www.ruby-forum.com/t/code-review-rails-12/138708/1 "2008-05-27T02:13:54Z")

</div>

tfpt review “/shelveset:rails-12;REDMOND\jflam”

- Adds an implementation of Kernel#rand. Passes all specs
- Fixes bug where you are matching a regex against a nil (both #match  
and #=~)
- Fixes glob for matching directory names (paths that end with / are  
assumed to refer to dirs and not files)
- Fixes bug in constructing Digest objects in OpenSSL

Thanks,  
-John

---

<div class="post-metadata">

**Author:** ![John\_LSSIRONRUBY](https://www.ruby-forum.com/letter_avatar_proxy/v4/letter/j/4491bb/32.png) [@John\_LSSIRONRUBY](https://www.ruby-forum.com/u/John_LSSIRONRUBY)\
**Post date:** [May 27, 2008, 6:09am UTC](https://www.ruby-forum.com/t/code-review-rails-12/138708/2 "2008-05-27T06:09:42Z")

</div>

Looks good. The final “rand” implementation would need to use a  
“srand”-seeded generator associated with RubyExecutionContext though.

Tomas